Re: [PATCH v5 2/2] ARM: module: Fix function kallsyms on Thumb-2

2018-12-14 Thread Vincent Whitchurch
On Thu, Dec 06, 2018 at 06:29:20PM +0100, Jessica Yu wrote: > Also, do you mind if I drop the module_ prefix from > module_kallsyms_symbol_value()? I recently submitted some internal > module kallsyms cleanups [1] and there we have the newly renamed > kallsyms_symbol_name(), so I think it'd be nice

Re: [PATCH v5 2/2] ARM: module: Fix function kallsyms on Thumb-2

2018-12-06 Thread Jessica Yu
+++ Vincent Whitchurch [04/12/18 15:14 +0100]: Thumb-2 functions have the lowest bit set in the symbol value in the symtab. When kallsyms are generated for the vmlinux, the kallsyms are generated from the output of nm, and nm clears the lowest bit. $ arm-linux-gnueabihf-readelf -a vmlinux | gre