Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c

2015-06-03 Thread Thomas Gleixner
On Tue, 2 Jun 2015, Bin Gao wrote: > On Tue, Jun 02, 2015 at 11:07:39PM +0200, Thomas Gleixner wrote: > > What about the memory mapped uarts which have been source of trouble > > in the past? > > > > Thanks, > > > > tglx > > Not sure which specific early console you are referring to. > Curr

Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c

2015-06-03 Thread Bin Gao
On Wed, Jun 03, 2015 at 08:35:29AM -0400, Peter Hurley wrote: > > +/* x86 uses "earlyprintk=xxx", so we keep the compatibility here */ > > +#ifdef CONFIG_X86 > > +static int __init param_setup_earlycon_x86(char *buf) > > +{ > > + return param_setup_earlycon(buf); > > +} > > +early_param("earlypri

Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c

2015-06-03 Thread Peter Hurley
Gnomes; Peter Hurley; Jiri Slaby; Borislav Petkov; Anderson, Stuart > R; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from > early_prink.c > > On Tue, Jun 02, 2015 at 11:07:39PM +0200, Thomas Gleixner wrote: >> What

Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c

2015-06-03 Thread Peter Hurley
On 05/29/2015 02:41 PM, Bin Gao wrote: > The arch independent uart8250 early console driver has good > support for memory mapped and io port based 8250 uarts. Since > pci is arch independent so it's natural to extend uart8250 to > support mem, io and pci. Hence pci uart early console in > arch/x86/

Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c

2015-06-02 Thread Bin Gao
On Wed, Jun 03, 2015 at 12:16:36AM +, Anderson, Stuart R wrote: > Bin, et al, > > What we are losing here is the ability to specify a UART by its bus address > instead of just supplying the memory or io address. There are some cases > where this is useful, though I admit it is probably not goi

Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c

2015-06-02 Thread Bin Gao
On Tue, Jun 02, 2015 at 01:37:52PM -0700, Yinghai Lu wrote: > how about > earlyprintk=serial,ttyS0 > earlyprintk=ttyS0 > > Thanks > > Yinghai Yes, both work. -Bin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org Mor

RE: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c

2015-06-02 Thread Anderson, Stuart R
; H. Peter Anvin; Greg Kroah-Hartman; One Thousand Gnomes; Peter Hurley; Jiri Slaby; Borislav Petkov; Anderson, Stuart R; linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c On Tue, Jun 02, 2015 at 11:07:39PM +0200, Thomas Glei

Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c

2015-06-02 Thread Bin Gao
On Tue, Jun 02, 2015 at 11:07:39PM +0200, Thomas Gleixner wrote: > What about the memory mapped uarts which have been source of trouble > in the past? > > Thanks, > > tglx Not sure which specific early console you are referring to. Currently we have serial, ttyS, vga, dbgp, xen, efi and pc

Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c

2015-06-02 Thread Bin Gao
On Tue, Jun 02, 2015 at 11:46:02PM +0200, Ingo Molnar wrote: > So the format on x86 used to be: > > earlyprintk=serial,ttyS0,115200 > > does that work too? > > Thanks, > > Ingo Just tested it, and yes it works. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" i

Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c

2015-06-02 Thread Ingo Molnar
* Bin Gao wrote: > On Tue, Jun 02, 2015 at 01:54:33PM +0200, Ingo Molnar wrote: > > > > * Bin Gao wrote: > > > > > The arch independent uart8250 early console driver has good support for > > > memory > > > mapped and io port based 8250 uarts. Since pci is arch independent so > > > it's >

Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c

2015-06-02 Thread Thomas Gleixner
On Tue, 2 Jun 2015, Bin Gao wrote: > On Tue, Jun 02, 2015 at 01:54:33PM +0200, Ingo Molnar wrote: > > > > * Bin Gao wrote: > > > > > The arch independent uart8250 early console driver has good support for > > > memory > > > mapped and io port based 8250 uarts. Since pci is arch independent so

Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c

2015-06-02 Thread Yinghai Lu
On Tue, Jun 2, 2015 at 12:20 PM, Bin Gao wrote: >> >> In what way have you tested this change, does serial-earlyprintk still work >> on x86 >> after the change? > > Yes, this patch was tested with earlyprintk=serial,0x3f8 on my x86 box and > the early console worked fine. how about earlyprintk=s

Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c

2015-06-02 Thread Bin Gao
On Tue, Jun 02, 2015 at 01:54:33PM +0200, Ingo Molnar wrote: > > * Bin Gao wrote: > > > The arch independent uart8250 early console driver has good support for > > memory > > mapped and io port based 8250 uarts. Since pci is arch independent so it's > > natural to extend uart8250 to support m

Re: [PATCH v5 2/2] arch/x86: remove pci uart early console from early_prink.c

2015-06-02 Thread Ingo Molnar
* Bin Gao wrote: > The arch independent uart8250 early console driver has good support for > memory > mapped and io port based 8250 uarts. Since pci is arch independent so it's > natural to extend uart8250 to support mem, io and pci. Hence pci uart early > console in arch/x86/kernel_printk.c