On Fri, Jan 20, 2017 at 12:30:16PM -0500, Vivien Didelot wrote:
> Hi Gregory,
>
> Gregory CLEMENT writes:
>
> > If there a series about to be merged I can rebase my series on it. Else
> > I propose to keep it and convert the family check to ops when you will
> > send the series for it.
>
> I am
Hi Vvien and Andrew,
On ven., janv. 20 2017, Andrew Lunn wrote:
> On Thu, Jan 19, 2017 at 05:26:03PM -0500, Vivien Didelot wrote:
>> Gregory CLEMENT writes:
>>
>> > +static bool mv88e6xxx_6341_family(struct mv88e6xxx_chip *chip)
>> > +{
>> > + return chip->info->family == MV88E6XXX_FAMILY_6
Hi Gregory,
Gregory CLEMENT writes:
> If there a series about to be merged I can rebase my series on it. Else
> I propose to keep it and convert the family check to ops when you will
> send the series for it.
I am reworking the VTU operations, but not these port operations yet.
I will take care
mv88e6xxx_6341_family is checked twice, on line 2606 and 2607.
julia
-- Forwarded message --
Date: Fri, 20 Jan 2017 19:38:12 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: Re: [PATCH v5 2/2] net: dsa: mv88e6xxx: Add support for ethernet switch
Hi Andrew,
Andrew Lunn writes:
>> Maybe I missed it, Andrew, can you confirm that 6341 is a proper Marvell
>> family of switch chips?
>
> My understand is that it is. Marvell have not added it to DSDT. There
> is a new SDK called UMSD, also GPLv2 and BSD. They call this family
> Topaz, and the 6
On Thu, Jan 19, 2017 at 05:26:03PM -0500, Vivien Didelot wrote:
> Gregory CLEMENT writes:
>
> > +static bool mv88e6xxx_6341_family(struct mv88e6xxx_chip *chip)
> > +{
> > + return chip->info->family == MV88E6XXX_FAMILY_6341;
> > +}
>
> I don't want to see these erronous family checks anymore,
Gregory CLEMENT writes:
> +static bool mv88e6xxx_6341_family(struct mv88e6xxx_chip *chip)
> +{
> + return chip->info->family == MV88E6XXX_FAMILY_6341;
> +}
I don't want to see these erronous family checks anymore, but I cannot
blame you for adding it since not all the code is moved to ops ye
7 matches
Mail list logo