Re: [PATCH v5 2/3] mfd: qcom-rpm: Driver for the Qualcomm RPM

2014-08-22 Thread Bjorn Andersson
On Fri, Aug 22, 2014 at 12:50 AM, Lee Jones wrote: > On Thu, 21 Aug 2014, Bjorn Andersson wrote: >> On Thu 21 Aug 06:22 PDT 2014, Lee Jones wrote: >> > > +struct qcom_rpm *dev_get_qcom_rpm(struct device *dev) >> > > +{ >> > > + return dev_get_drvdata(dev); >> > > +} >> > > +EXPORT_SYMBOL(dev_get_q

Re: [PATCH v5 2/3] mfd: qcom-rpm: Driver for the Qualcomm RPM

2014-08-22 Thread Lee Jones
On Thu, 21 Aug 2014, Bjorn Andersson wrote: > On Thu 21 Aug 06:22 PDT 2014, Lee Jones wrote: > > > +struct qcom_rpm *dev_get_qcom_rpm(struct device *dev) > > > +{ > > > + return dev_get_drvdata(dev); > > > +} > > > +EXPORT_SYMBOL(dev_get_qcom_rpm); > > > > No need for this at all. Use dev_get_drv

Re: [PATCH v5 2/3] mfd: qcom-rpm: Driver for the Qualcomm RPM

2014-08-21 Thread Bjorn Andersson
On Thu 21 Aug 06:22 PDT 2014, Lee Jones wrote: > > diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c > > +static const struct qcom_rpm_data msm8660_template = { > > + .version = -1, > > -1? > 2 would be a better number... > > + .resource_table = msm8660_rpm_resource_table, > > +

Re: [PATCH v5 2/3] mfd: qcom-rpm: Driver for the Qualcomm RPM

2014-08-21 Thread Lee Jones
On Mon, 11 Aug 2014, Bjorn Andersson wrote: > Driver for the Resource Power Manager (RPM) found in Qualcomm 8660, 8960 > and 8064 based devices. The driver exposes resources that child drivers > can operate on; to implementing regulator, clock and bus frequency > drivers. > > Signed-off-by: Bjorn