On Tue, Sep 30, 2014 at 3:09 PM, David Laight wrote:
>> > +static inline int gbe_phy_link_status(struct gbe_slave *slave)
>> > +{
>> > + if (!slave->phy)
>> > + return 1;
>> > +
>> > + if (slave->phy->link)
>> > + return 1;
>> > +
>> > + return 0;
>> > +}
>>
>> Please use
From: David Miller
> From: Santosh Shilimkar
> Date: Thu, 25 Sep 2014 13:48:36 -0400
>
> > +static inline int gbe_phy_link_status(struct gbe_slave *slave)
> > +{
> > + if (!slave->phy)
> > + return 1;
> > +
> > + if (slave->phy->link)
> > + return 1;
> > +
> > + return 0
On Monday 29 September 2014 04:12 PM, David Miller wrote:
> From: Santosh Shilimkar
> Date: Mon, 29 Sep 2014 16:02:24 -0400
>
>> We are badly missing mainline network driver support for the Keystone
>> and hence I request you to help here.
>
> It is absolutely not reasonable for you depend speci
From: Santosh Shilimkar
Date: Mon, 29 Sep 2014 16:02:24 -0400
> We are badly missing mainline network driver support for the Keystone
> and hence I request you to help here.
It is absolutely not reasonable for you depend specifically upon me
for top-level review of a given change, sorry.
--
To u
On Monday 29 September 2014 03:52 PM, David Miller wrote:
> From: Santosh Shilimkar
> Date: Thu, 25 Sep 2014 13:48:36 -0400
>
>> +static inline int gbe_phy_link_status(struct gbe_slave *slave)
>> +{
>> +if (!slave->phy)
>> +return 1;
>> +
>> +if (slave->phy->link)
>> +
From: Santosh Shilimkar
Date: Thu, 25 Sep 2014 13:48:36 -0400
> +static inline int gbe_phy_link_status(struct gbe_slave *slave)
> +{
> + if (!slave->phy)
> + return 1;
> +
> + if (slave->phy->link)
> + return 1;
> +
> + return 0;
> +}
Please use 'bool' as the
6 matches
Mail list logo
