Re: [PATCH v5 2/7] mm, devm_memremap_pages: Kill mapping "System RAM" support

2018-09-18 Thread Jerome Glisse
On Wed, Sep 12, 2018 at 07:22:11PM -0700, Dan Williams wrote: > Given the fact that devm_memremap_pages() requires a percpu_ref that is > torn down by devm_memremap_pages_release() the current support for > mapping RAM is broken. > > Support for remapping "System RAM" has been broken since the beg

Re: [PATCH v5 2/7] mm, devm_memremap_pages: Kill mapping "System RAM" support

2018-09-14 Thread Dan Williams
On Fri, Sep 14, 2018 at 6:14 AM, Christoph Hellwig wrote: > On Wed, Sep 12, 2018 at 07:22:11PM -0700, Dan Williams wrote: >> Given the fact that devm_memremap_pages() requires a percpu_ref that is >> torn down by devm_memremap_pages_release() the current support for >> mapping RAM is broken. > > I

Re: [PATCH v5 2/7] mm, devm_memremap_pages: Kill mapping "System RAM" support

2018-09-14 Thread Christoph Hellwig
On Wed, Sep 12, 2018 at 07:22:11PM -0700, Dan Williams wrote: > Given the fact that devm_memremap_pages() requires a percpu_ref that is > torn down by devm_memremap_pages_release() the current support for > mapping RAM is broken. I agree. Do you remember why we even added it in the first place?

Re: [PATCH v5 2/7] mm, devm_memremap_pages: Kill mapping "System RAM" support

2018-09-13 Thread Logan Gunthorpe
On 12/09/18 08:22 PM, Dan Williams wrote: > Given the fact that devm_memremap_pages() requires a percpu_ref that is > torn down by devm_memremap_pages_release() the current support for > mapping RAM is broken. > > Support for remapping "System RAM" has been broken since the beginning > and ther