Re: [PATCH v5 4/7] platform/chrome: Add Chrome OS EC userspace device interface

2015-02-26 Thread Olof Johansson
On Thu, Feb 26, 2015 at 1:08 AM, Javier Martinez Canillas wrote: > Hello Olof, > > Thanks a lot for your feedback. > > On 02/26/2015 02:13 AM, Gwendal Grignou wrote: >> Olof, >> >> I think the way Javier did it is fine, the 'major' of the ioctl is >> 0xEC, from ':'. >> >> Gwendal. >> > > As Gwenda

Re: [PATCH v5 4/7] platform/chrome: Add Chrome OS EC userspace device interface

2015-02-26 Thread Javier Martinez Canillas
Hello Olof, Thanks a lot for your feedback. On 02/26/2015 02:13 AM, Gwendal Grignou wrote: > Olof, > > I think the way Javier did it is fine, the 'major' of the ioctl is > 0xEC, from ':'. > > Gwendal. > As Gwendal said, I deliberately changed the IOCTL mayor number to make it different in both

Re: [PATCH v5 4/7] platform/chrome: Add Chrome OS EC userspace device interface

2015-02-25 Thread Gwendal Grignou
Olof, I think the way Javier did it is fine, the 'major' of the ioctl is 0xEC, from ':'. Gwendal. On Wed, Feb 25, 2015 at 4:54 PM, Olof Johansson wrote: > On Mon, Feb 02, 2015 at 12:26:25PM +0100, Javier Martinez Canillas wrote: >> From: Bill Richardson >> >> This patch adds a device interface

Re: [PATCH v5 4/7] platform/chrome: Add Chrome OS EC userspace device interface

2015-02-25 Thread Olof Johansson
On Mon, Feb 02, 2015 at 12:26:25PM +0100, Javier Martinez Canillas wrote: > From: Bill Richardson > > This patch adds a device interface to access the > Chrome OS Embedded Controller from user-space. > > Signed-off-by: Bill Richardson > Reviewed-by: Simon Glass > Signed-off-by: Javier Martinez