Re: [PATCH v5 5/6] iommu/mediatek: Add mt8173 IOMMU driver

2015-10-31 Thread Yong Wu
On Tue, 2015-10-27 at 13:25 +, Robin Murphy wrote: > On 09/10/15 03:23, Yong Wu wrote: > [...] > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > >

Re: [PATCH v5 5/6] iommu/mediatek: Add mt8173 IOMMU driver

2015-10-27 Thread Robin Murphy
On 09/10/15 03:23, Yong Wu wrote: [...] +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include Nit: ordering? +#include +#include "io-pgtable.h" [...] +struct mtk_iommu_data { + void __iomem

Re: [PATCH v5 5/6] iommu/mediatek: Add mt8173 IOMMU driver

2015-10-25 Thread Yong Wu
On Wed, 2015-10-14 at 14:53 +0200, Joerg Roedel wrote: > On Fri, Oct 09, 2015 at 10:23:07AM +0800, Yong Wu wrote: > > + /* > > +* There is a domain for each a iommu device in normal case. > > +* But MTK only has one iommu domain called the m4u domain which all > > +* the multimedia HW

Re: [PATCH v5 5/6] iommu/mediatek: Add mt8173 IOMMU driver

2015-10-14 Thread Joerg Roedel
On Fri, Oct 09, 2015 at 10:23:07AM +0800, Yong Wu wrote: > + /* > + * There is a domain for each a iommu device in normal case. > + * But MTK only has one iommu domain called the m4u domain which all > + * the multimedia HW share. Here we reserve one as the m4u domain and > +