Re: [PATCH v5 6/7] mm: reparent slab memory on cgroup removal

2019-05-28 Thread Johannes Weiner
On Tue, May 28, 2019 at 07:58:17PM +, Roman Gushchin wrote: > On Tue, May 28, 2019 at 09:33:02PM +0300, Vladimir Davydov wrote: > > On Tue, May 21, 2019 at 01:07:34PM -0700, Roman Gushchin wrote: > > > Let's reparent memcg slab memory on memcg offlining. This allows us > > > to release the memo

Re: [PATCH v5 6/7] mm: reparent slab memory on cgroup removal

2019-05-28 Thread Roman Gushchin
On Tue, May 28, 2019 at 11:11:02PM +0300, Vladimir Davydov wrote: > On Tue, May 28, 2019 at 07:58:17PM +, Roman Gushchin wrote: > > It looks like outstanding questions are: > > 1) synchronization around the dying flag > > 2) removing CONFIG_SLOB in 2/7 > > 3) early sysfs_slab_remove() > > 4) me

Re: [PATCH v5 6/7] mm: reparent slab memory on cgroup removal

2019-05-28 Thread Vladimir Davydov
On Tue, May 28, 2019 at 07:58:17PM +, Roman Gushchin wrote: > It looks like outstanding questions are: > 1) synchronization around the dying flag > 2) removing CONFIG_SLOB in 2/7 > 3) early sysfs_slab_remove() > 4) mem_cgroup_from_kmem in 7/7 > > Please, let me know if I missed anything. Also

Re: [PATCH v5 6/7] mm: reparent slab memory on cgroup removal

2019-05-28 Thread Roman Gushchin
On Tue, May 28, 2019 at 09:33:02PM +0300, Vladimir Davydov wrote: > On Tue, May 21, 2019 at 01:07:34PM -0700, Roman Gushchin wrote: > > Let's reparent memcg slab memory on memcg offlining. This allows us > > to release the memory cgroup without waiting for the last outstanding > > kernel object (e.

Re: [PATCH v5 6/7] mm: reparent slab memory on cgroup removal

2019-05-28 Thread Vladimir Davydov
On Tue, May 21, 2019 at 01:07:34PM -0700, Roman Gushchin wrote: > Let's reparent memcg slab memory on memcg offlining. This allows us > to release the memory cgroup without waiting for the last outstanding > kernel object (e.g. dentry used by another application). > > So instead of reparenting all