Re: [PATCH v5 7/7] Documentation/dev-tools: Add kselftest_harness documentation

2017-06-05 Thread Shuah Khan
On 06/03/2017 05:17 AM, Mickaël Salaün wrote: > > On 02/06/2017 22:02, Shuah Khan wrote: >> Hi Mickaël, >> >> On 05/26/2017 12:44 PM, Mickaël Salaün wrote: >>> Add ReST metadata to kselftest_harness.h to be able to include the >>> comments in the Sphinx documentation. >>> >> >> These don't belong

Re: [PATCH v5 7/7] Documentation/dev-tools: Add kselftest_harness documentation

2017-06-03 Thread Mickaël Salaün
On 02/06/2017 22:02, Shuah Khan wrote: > Hi Mickaël, > > On 05/26/2017 12:44 PM, Mickaël Salaün wrote: >> Add ReST metadata to kselftest_harness.h to be able to include the >> comments in the Sphinx documentation. >> > > These don't belong the change log. These types of changes are for > reviewe

Re: [PATCH v5 7/7] Documentation/dev-tools: Add kselftest_harness documentation

2017-06-02 Thread Shuah Khan
Hi Mickaël, On 05/26/2017 12:44 PM, Mickaël Salaün wrote: > Add ReST metadata to kselftest_harness.h to be able to include the > comments in the Sphinx documentation. > These don't belong the change log. These types of changes are for reviewers benefit and should be added between the sign-of blo

Re: [PATCH v5 7/7] Documentation/dev-tools: Add kselftest_harness documentation

2017-05-26 Thread Kees Cook
On Fri, May 26, 2017 at 11:44 AM, Mickaël Salaün wrote: > Add ReST metadata to kselftest_harness.h to be able to include the > comments in the Sphinx documentation. > > Changes since v4: > * exclude the TEST_API() changes (requested by Kees Cook) > > Changes since v3: > * document macros as actual