Re: [PATCH v5 7/8] dmaengine: add a driver for Intel integrated DMA 64-bit

2015-07-23 Thread Andy Shevchenko
On Wed, 2015-07-22 at 10:27 +0530, Vinod Koul wrote: > On Tue, Jul 21, 2015 at 10:08:28AM +0300, Andy Shevchenko wrote: > > On Tue, Jul 21, 2015 at 7:50 AM, Vinod Koul > > wrote: > > > On Mon, Jul 20, 2015 at 11:46:28AM +0300, Andy Shevchenko wrote: > > > > > > +static void idma64_chan_init(struc

Re: [PATCH v5 7/8] dmaengine: add a driver for Intel integrated DMA 64-bit

2015-07-21 Thread Vinod Koul
On Tue, Jul 21, 2015 at 10:08:28AM +0300, Andy Shevchenko wrote: > On Tue, Jul 21, 2015 at 7:50 AM, Vinod Koul wrote: > > On Mon, Jul 20, 2015 at 11:46:28AM +0300, Andy Shevchenko wrote: > >> >> +static void idma64_chan_init(struct idma64 *idma64, struct idma64_chan > >> >> *idma64c) > >> >> +{ >

Re: [PATCH v5 7/8] dmaengine: add a driver for Intel integrated DMA 64-bit

2015-07-21 Thread Andy Shevchenko
On Tue, Jul 21, 2015 at 7:50 AM, Vinod Koul wrote: > On Mon, Jul 20, 2015 at 11:46:28AM +0300, Andy Shevchenko wrote: >> >> +static void idma64_chan_init(struct idma64 *idma64, struct idma64_chan >> >> *idma64c) >> >> +{ >> >> + u32 cfghi = IDMA64C_CFGH_SRC_PER(1) | IDMA64C_CFGH_DST_PER(0); >

Re: [PATCH v5 7/8] dmaengine: add a driver for Intel integrated DMA 64-bit

2015-07-20 Thread Vinod Koul
On Mon, Jul 20, 2015 at 11:46:28AM +0300, Andy Shevchenko wrote: > >> +static void idma64_chan_init(struct idma64 *idma64, struct idma64_chan > >> *idma64c) > >> +{ > >> + u32 cfghi = IDMA64C_CFGH_SRC_PER(1) | IDMA64C_CFGH_DST_PER(0); > >> + u32 cfglo = 0; > >> + > >> + /* Enforce FIFO

Re: [PATCH v5 7/8] dmaengine: add a driver for Intel integrated DMA 64-bit

2015-07-20 Thread Andy Shevchenko
On Fri, Jul 17, 2015 at 7:38 AM, Vinod Koul wrote: > On Mon, Jul 06, 2015 at 03:22:13PM +0300, Andy Shevchenko wrote: >> +config IDMA64 >> + tristate "Intel integrated DMA 64-bit support" >> + select DMA_ENGINE >> + select DMA_VIRTUAL_CHANNELS > no help text? Will fix. > >> +static v

Re: [PATCH v5 7/8] dmaengine: add a driver for Intel integrated DMA 64-bit

2015-07-16 Thread Vinod Koul
On Mon, Jul 06, 2015 at 03:22:13PM +0300, Andy Shevchenko wrote: > +config IDMA64 > + tristate "Intel integrated DMA 64-bit support" > + select DMA_ENGINE > + select DMA_VIRTUAL_CHANNELS no help text? > +static void idma64_chan_init(struct idma64 *idma64, struct idma64_chan > *idma64c