Re: [PATCH v6] mm: Add memory allocation watchdog kernel thread.

2017-02-21 Thread Tetsuo Handa
Johannes, any questions/comments on this patch? I'd like to send to linux-next because this patch will be useful for examining problems like "Bug 192981 - page allocation stalls". I think that this patch will remain be useful as long as we use direct reclaim. Tetsuo Handa wrote: > Michal Hocko wro

Re: [PATCH v6] mm: Add memory allocation watchdog kernel thread.

2017-01-26 Thread Tetsuo Handa
Michal Hocko wrote: > On Wed 25-01-17 13:11:50, Johannes Weiner wrote: > [...] > > >From 6420cae52cac8167bd5fb19f45feed2d540bc11d Mon Sep 17 00:00:00 2001 > > From: Johannes Weiner > > Date: Wed, 25 Jan 2017 12:57:20 -0500 > > Subject: [PATCH] mm: page_alloc: __GFP_NOWARN shouldn't suppress stall

Re: [PATCH v6] mm: Add memory allocation watchdog kernel thread.

2017-01-25 Thread Michal Hocko
On Wed 25-01-17 14:22:45, Johannes Weiner wrote: > On Wed, Jan 25, 2017 at 07:45:49PM +0100, Michal Hocko wrote: > > On Wed 25-01-17 13:11:50, Johannes Weiner wrote: > > [...] > > > >From 6420cae52cac8167bd5fb19f45feed2d540bc11d Mon Sep 17 00:00:00 2001 > > > From: Johannes Weiner > > > Date: Wed,

Re: [PATCH v6] mm: Add memory allocation watchdog kernel thread.

2017-01-25 Thread Minchan Kim
On Wed, Jan 25, 2017 at 01:11:50PM -0500, Johannes Weiner wrote: > On Sun, Nov 06, 2016 at 04:15:01PM +0900, Tetsuo Handa wrote: > > +- Why need to use it? > > + > > +Currently, when something went wrong inside memory allocation request, > > +the system might stall without any kernel messages. > >

Re: [PATCH v6] mm: Add memory allocation watchdog kernel thread.

2017-01-25 Thread Johannes Weiner
On Wed, Jan 25, 2017 at 07:45:49PM +0100, Michal Hocko wrote: > On Wed 25-01-17 13:11:50, Johannes Weiner wrote: > [...] > > >From 6420cae52cac8167bd5fb19f45feed2d540bc11d Mon Sep 17 00:00:00 2001 > > From: Johannes Weiner > > Date: Wed, 25 Jan 2017 12:57:20 -0500 > > Subject: [PATCH] mm: page_all

Re: [PATCH v6] mm: Add memory allocation watchdog kernel thread.

2017-01-25 Thread Michal Hocko
On Wed 25-01-17 13:11:50, Johannes Weiner wrote: [...] > >From 6420cae52cac8167bd5fb19f45feed2d540bc11d Mon Sep 17 00:00:00 2001 > From: Johannes Weiner > Date: Wed, 25 Jan 2017 12:57:20 -0500 > Subject: [PATCH] mm: page_alloc: __GFP_NOWARN shouldn't suppress stall > warnings > > __GFP_NOWARN, w

Re: [PATCH v6] mm: Add memory allocation watchdog kernel thread.

2017-01-25 Thread Johannes Weiner
On Sun, Nov 06, 2016 at 04:15:01PM +0900, Tetsuo Handa wrote: > +- Why need to use it? > + > +Currently, when something went wrong inside memory allocation request, > +the system might stall without any kernel messages. > + > +Although there is khungtaskd kernel thread as an asynchronous monitoring

Re: [PATCH v6] mm: Add memory allocation watchdog kernel thread.

2017-01-25 Thread Michal Hocko
On Wed 25-01-17 23:03:43, Tetsuo Handa wrote: > Andrew, what do you think about this version? There seems to be no objections. Well, this is not true. My main objection still holds. I simply do not think all the additional code is really worth it. Not enough to nack the patch, though, of course. I

Re: [PATCH v6] mm: Add memory allocation watchdog kernel thread.

2017-01-25 Thread Tetsuo Handa
Andrew, what do you think about this version? There seems to be no objections. This patch should be helpful for initial research of minutes-lasting stalls (e.g. http://lkml.kernel.org/r/20170123135111.13ac3e47110de10a4bd50...@linux-foundation.org ) and proving whether what Michal does not think

Re: [PATCH v6] mm: Add memory allocation watchdog kernel thread.

2016-12-28 Thread Tetsuo Handa
Michal Hocko wrote at http://lkml.kernel.org/r/20161227105715.ge1...@dhcp22.suse.cz : > On Tue 27-12-16 19:39:28, Tetsuo Handa wrote: > > Michal Hocko wrote: > > > I am not saying that the current code works perfectly when we are > > > hitting the direct reclaim close to the OOM but improving that

Re: [PATCH v6] mm: Add memory allocation watchdog kernel thread.

2016-12-15 Thread Tetsuo Handa
Tetsuo Handa wrote: > This patch adds a watchdog which periodically reports number of memory > allocating tasks, dying tasks and OOM victim tasks when some task is > spending too long time inside __alloc_pages_slowpath(). This patch also > serves as a hook for obtaining additional information using