Re: [PATCH v6] modules: introduce the MODULE_SCMVERSION config

2021-02-08 Thread Will McVicker
Thanks Jessica for all the reviews. I guess we can let this die here and I'll carry it downstream. At least it's all here for others to see. Thanks, Will On Wed, Feb 3, 2021 at 7:54 AM Greg Kroah-Hartman wrote: > > On Wed, Feb 03, 2021 at 04:46:16PM +0100, Jessica Yu wrote: > > +++ Will McVicker

Re: [PATCH v6] modules: introduce the MODULE_SCMVERSION config

2021-02-03 Thread Greg Kroah-Hartman
On Wed, Feb 03, 2021 at 04:46:16PM +0100, Jessica Yu wrote: > +++ Will McVicker [21/01/21 21:36 +]: > > Config MODULE_SCMVERSION introduces a new module attribute -- > > `scmversion` -- which can be used to identify a given module's SCM > > version. This is very useful for developers that upda

Re: [PATCH v6] modules: introduce the MODULE_SCMVERSION config

2021-02-03 Thread Jessica Yu
+++ Will McVicker [21/01/21 21:36 +]: Config MODULE_SCMVERSION introduces a new module attribute -- `scmversion` -- which can be used to identify a given module's SCM version. This is very useful for developers that update their kernel independently from their kernel modules or vice-versa si

Re: [PATCH v6] modules: introduce the MODULE_SCMVERSION config

2021-02-02 Thread Will McVicker
Hi Christoph, Did you see Saravana's response to you in version 5? I'd love to hear your thoughts. Thanks, Will On Mon, Feb 1, 2021 at 11:42 PM Christoph Hellwig wrote: > > Just to deposit my opposition again: I don't think this hack for your > out of tree builds has any place in the kernel tr

Re: [PATCH v6] modules: introduce the MODULE_SCMVERSION config

2021-02-01 Thread Christoph Hellwig
Just to deposit my opposition again: I don't think this hack for your out of tree builds has any place in the kernel tree.

Re: [PATCH v6] modules: introduce the MODULE_SCMVERSION config

2021-02-01 Thread Will McVicker
Hi Jessica and Masahiro, Could I get a final look at the latest patchset please? All the issues have been addressed thus far. Thanks, Will On Thu, Jan 21, 2021 at 1:36 PM Will McVicker wrote: > > Config MODULE_SCMVERSION introduces a new module attribute -- > `scmversion` -- which can be used t