Re: [PATCH v6] serial: 8250_uniphier: add UniPhier serial driver

2015-05-28 Thread Masahiro Yamada
2015-05-27 0:08 GMT+09:00 Shevchenko, Andriy : > On Tue, 2015-05-26 at 15:28 +0100, Alan Cox wrote: >> > > + >> > > +#define UNIPHIER_UART_CHAR_FCR 3 /* Character / FIFO Control >> > > Register */ >> > > +#define UNIPHIER_UART_LCR_MCR4 /* Line/Modem Control Register >> > > */ >>

Re: [PATCH v6] serial: 8250_uniphier: add UniPhier serial driver

2015-05-26 Thread Shevchenko, Andriy
On Tue, 2015-05-26 at 15:28 +0100, Alan Cox wrote: > > > + > > > +#define UNIPHIER_UART_CHAR_FCR 3 /* Character / FIFO Control > > > Register */ > > > +#define UNIPHIER_UART_LCR_MCR4 /* Line/Modem Control Register > > > */ > > > +#define UNIPHIER_UART_LCR_SHIFT8 > > >

Re: [PATCH v6] serial: 8250_uniphier: add UniPhier serial driver

2015-05-26 Thread Alan Cox
> > + > > +#define UNIPHIER_UART_CHAR_FCR 3 /* Character / FIFO Control > > Register */ > > +#define UNIPHIER_UART_LCR_MCR 4 /* Line/Modem Control Register > > */ > > +#define UNIPHIER_UART_LCR_SHIFT 8 > > Indentation problem, needs to be fixed. If you are going to revie

Re: [PATCH v6] serial: 8250_uniphier: add UniPhier serial driver

2015-05-25 Thread Masahiro Yamada
Hi Andy, 2015-05-25 18:14 GMT+09:00 Shevchenko, Andriy : > On Mon, 2015-05-25 at 12:44 +0900, Masahiro Yamada wrote: >> Add the driver for on-chip UART used on UniPhier SoCs. >> >> This hardware is similar to 8250, but the register mapping is >> slightly different: >> - The offset to FCR, MCR i

Re: [PATCH v6] serial: 8250_uniphier: add UniPhier serial driver

2015-05-25 Thread Shevchenko, Andriy
On Mon, 2015-05-25 at 12:44 +0900, Masahiro Yamada wrote: > Add the driver for on-chip UART used on UniPhier SoCs. > > This hardware is similar to 8250, but the register mapping is > slightly different: > - The offset to FCR, MCR is different. > - The divisor latch access bit does not exist.