Re: [PATCH v6 00/14] soundwire: Add a new SoundWire subsystem

2017-12-19 Thread Greg Kroah-Hartman
On Thu, Dec 14, 2017 at 03:09:14PM +, Mark Brown wrote: > On Thu, Dec 14, 2017 at 01:49:49PM +0100, Greg Kroah-Hartman wrote: > > > Ok, but that feels a bit rushed, as I'm guessing those sysfs files are > > essencial for the use of the hardware. To not include them feels odd to > > me :) > >

Re: [PATCH v6 00/14] soundwire: Add a new SoundWire subsystem

2017-12-14 Thread Mark Brown
On Thu, Dec 14, 2017 at 01:49:49PM +0100, Greg Kroah-Hartman wrote: > Ok, but that feels a bit rushed, as I'm guessing those sysfs files are > essencial for the use of the hardware. To not include them feels odd to > me :) As a reviewer if we can get the rest of the series moving so that there's

Re: [PATCH v6 00/14] soundwire: Add a new SoundWire subsystem

2017-12-14 Thread Vinod Koul
On Thu, Dec 14, 2017 at 01:49:49PM +0100, Greg Kroah-Hartman wrote: > On Thu, Dec 14, 2017 at 04:23:20PM +0530, Vinod Koul wrote: > > On Thu, Dec 14, 2017 at 08:35:08AM +0100, Greg Kroah-Hartman wrote: > > > On Thu, Dec 14, 2017 at 11:19:31AM +0530, Vinod Koul wrote: > > > > Changes in v6: > > > >

Re: [PATCH v6 00/14] soundwire: Add a new SoundWire subsystem

2017-12-14 Thread Greg Kroah-Hartman
On Thu, Dec 14, 2017 at 04:23:20PM +0530, Vinod Koul wrote: > On Thu, Dec 14, 2017 at 08:35:08AM +0100, Greg Kroah-Hartman wrote: > > On Thu, Dec 14, 2017 at 11:19:31AM +0530, Vinod Koul wrote: > > > Changes in v6: > > > - Add reviewed/acked tags from Philippe, Pierre, Takashi and Greg > > > -

Re: [PATCH v6 00/14] soundwire: Add a new SoundWire subsystem

2017-12-14 Thread Vinod Koul
On Thu, Dec 14, 2017 at 10:02:22AM +0100, Philippe Ombredanne wrote: > Vinod, > > > Thanks! > > For the whole patch set my reviewed-by stands for the usage of SPDX > license tags. > (I am not qualified to review the rest ;) ) Thanks I have added your tag for review in the patches since v5 :) -

Re: [PATCH v6 00/14] soundwire: Add a new SoundWire subsystem

2017-12-14 Thread Vinod Koul
On Thu, Dec 14, 2017 at 08:35:08AM +0100, Greg Kroah-Hartman wrote: > On Thu, Dec 14, 2017 at 11:19:31AM +0530, Vinod Koul wrote: > > Changes in v6: > > - Add reviewed/acked tags from Philippe, Pierre, Takashi and Greg > > - Fix nitpicks from Takashi > > - Drop the sysfs patch for now > > Wa

Re: [PATCH v6 00/14] soundwire: Add a new SoundWire subsystem

2017-12-14 Thread Philippe Ombredanne
Vinod, On Thu, Dec 14, 2017 at 6:49 AM, Vinod Koul wrote: > We are going to merge this series thru sound tree, need Mark's ack on > regmap patch or to take it thru regmap tree. > > This patch series adds a new SoundWire subsystem which implements a > new MIPI bus protocol 'SoundWire'. > > The Sou

Re: [PATCH v6 00/14] soundwire: Add a new SoundWire subsystem

2017-12-13 Thread Greg Kroah-Hartman
On Thu, Dec 14, 2017 at 11:19:31AM +0530, Vinod Koul wrote: > Changes in v6: > - Add reviewed/acked tags from Philippe, Pierre, Takashi and Greg > - Fix nitpicks from Takashi > - Drop the sysfs patch for now Wait, why drop the sysfs patch entirely? You need those attributes, right? You als