Re: [PATCH v6 02/10] arm64: perf: Enable PMU counter direct access for perf event

2021-04-19 Thread Rob Herring
On Mon, Apr 19, 2021 at 11:14 AM Will Deacon wrote: > > On Thu, Apr 08, 2021 at 01:38:17PM -0500, Rob Herring wrote: > > On Thu, Apr 8, 2021 at 6:08 AM Mark Rutland wrote: > > > On Wed, Apr 07, 2021 at 01:44:37PM +0100, Will Deacon wrote: > > > > On Thu, Apr 01, 2021 at 02:45:21PM -0500, Rob

Re: [PATCH v6 02/10] arm64: perf: Enable PMU counter direct access for perf event

2021-04-19 Thread Will Deacon
On Thu, Apr 08, 2021 at 01:38:17PM -0500, Rob Herring wrote: > On Thu, Apr 8, 2021 at 6:08 AM Mark Rutland wrote: > > On Wed, Apr 07, 2021 at 01:44:37PM +0100, Will Deacon wrote: > > > On Thu, Apr 01, 2021 at 02:45:21PM -0500, Rob Herring wrote: > > > > On Wed, Mar 31, 2021 at 11:01 AM Will

Re: [PATCH v6 02/10] arm64: perf: Enable PMU counter direct access for perf event

2021-04-08 Thread Rob Herring
On Thu, Apr 8, 2021 at 6:08 AM Mark Rutland wrote: > > On Wed, Apr 07, 2021 at 01:44:37PM +0100, Will Deacon wrote: > > [Moving Mark to To: since I'd like his view on this] > > > > On Thu, Apr 01, 2021 at 02:45:21PM -0500, Rob Herring wrote: > > > On Wed, Mar 31, 2021 at 11:01 AM Will Deacon

Re: [PATCH v6 02/10] arm64: perf: Enable PMU counter direct access for perf event

2021-04-08 Thread Mark Rutland
On Wed, Apr 07, 2021 at 01:44:37PM +0100, Will Deacon wrote: > [Moving Mark to To: since I'd like his view on this] > > On Thu, Apr 01, 2021 at 02:45:21PM -0500, Rob Herring wrote: > > On Wed, Mar 31, 2021 at 11:01 AM Will Deacon wrote: > > > > > > On Tue, Mar 30, 2021 at 12:09:38PM -0500, Rob

Re: [PATCH v6 02/10] arm64: perf: Enable PMU counter direct access for perf event

2021-04-07 Thread Will Deacon
[Moving Mark to To: since I'd like his view on this] On Thu, Apr 01, 2021 at 02:45:21PM -0500, Rob Herring wrote: > On Wed, Mar 31, 2021 at 11:01 AM Will Deacon wrote: > > > > On Tue, Mar 30, 2021 at 12:09:38PM -0500, Rob Herring wrote: > > > On Tue, Mar 30, 2021 at 10:31 AM Will Deacon wrote:

Re: [PATCH v6 02/10] arm64: perf: Enable PMU counter direct access for perf event

2021-04-01 Thread Rob Herring
On Wed, Mar 31, 2021 at 11:01 AM Will Deacon wrote: > > On Tue, Mar 30, 2021 at 12:09:38PM -0500, Rob Herring wrote: > > On Tue, Mar 30, 2021 at 10:31 AM Will Deacon wrote: > > > > > > On Wed, Mar 10, 2021 at 05:08:29PM -0700, Rob Herring wrote: > > > > From: Raphael Gault > > > > > > > > Keep

Re: [PATCH v6 02/10] arm64: perf: Enable PMU counter direct access for perf event

2021-04-01 Thread Will Deacon
On Wed, Mar 31, 2021 at 12:52:11PM -0500, Rob Herring wrote: > On Wed, Mar 31, 2021 at 10:38 AM Will Deacon wrote: > > > > On Tue, Mar 30, 2021 at 04:08:11PM -0500, Rob Herring wrote: > > > On Tue, Mar 30, 2021 at 12:09 PM Rob Herring wrote: > > > > On Tue, Mar 30, 2021 at 10:31 AM Will Deacon

Re: [PATCH v6 02/10] arm64: perf: Enable PMU counter direct access for perf event

2021-03-31 Thread Rob Herring
On Wed, Mar 31, 2021 at 10:38 AM Will Deacon wrote: > > On Tue, Mar 30, 2021 at 04:08:11PM -0500, Rob Herring wrote: > > On Tue, Mar 30, 2021 at 12:09 PM Rob Herring wrote: > > > On Tue, Mar 30, 2021 at 10:31 AM Will Deacon wrote: > > > > The logic here feels like it > > > > could with a bit of

Re: [PATCH v6 02/10] arm64: perf: Enable PMU counter direct access for perf event

2021-03-31 Thread Will Deacon
On Tue, Mar 30, 2021 at 12:09:38PM -0500, Rob Herring wrote: > On Tue, Mar 30, 2021 at 10:31 AM Will Deacon wrote: > > > > On Wed, Mar 10, 2021 at 05:08:29PM -0700, Rob Herring wrote: > > > From: Raphael Gault > > > > > > Keep track of event opened with direct access to the hardware counters > >

Re: [PATCH v6 02/10] arm64: perf: Enable PMU counter direct access for perf event

2021-03-31 Thread Will Deacon
On Tue, Mar 30, 2021 at 04:08:11PM -0500, Rob Herring wrote: > On Tue, Mar 30, 2021 at 12:09 PM Rob Herring wrote: > > On Tue, Mar 30, 2021 at 10:31 AM Will Deacon wrote: > > > The logic here feels like it > > > could with a bit of untangling. > > > > Yes, I don't love it, but couldn't come up

Re: [PATCH v6 02/10] arm64: perf: Enable PMU counter direct access for perf event

2021-03-30 Thread Rob Herring
On Tue, Mar 30, 2021 at 12:09 PM Rob Herring wrote: > > On Tue, Mar 30, 2021 at 10:31 AM Will Deacon wrote: > > > > On Wed, Mar 10, 2021 at 05:08:29PM -0700, Rob Herring wrote: > > > From: Raphael Gault > > > > > > Keep track of event opened with direct access to the hardware counters > > > and

Re: [PATCH v6 02/10] arm64: perf: Enable PMU counter direct access for perf event

2021-03-30 Thread Rob Herring
On Tue, Mar 30, 2021 at 10:31 AM Will Deacon wrote: > > On Wed, Mar 10, 2021 at 05:08:29PM -0700, Rob Herring wrote: > > From: Raphael Gault > > > > Keep track of event opened with direct access to the hardware counters > > and modify permissions while they are open. > > > > The strategy used

Re: [PATCH v6 02/10] arm64: perf: Enable PMU counter direct access for perf event

2021-03-30 Thread Will Deacon
On Wed, Mar 10, 2021 at 05:08:29PM -0700, Rob Herring wrote: > From: Raphael Gault > > Keep track of event opened with direct access to the hardware counters > and modify permissions while they are open. > > The strategy used here is the same which x86 uses: every time an event > is mapped, the

Re: [PATCH v6 02/10] arm64: perf: Enable PMU counter direct access for perf event

2021-03-30 Thread Zachary Leaf
On 11/03/2021 00:08, Rob Herring wrote: In order to enable 64-bit counters for userspace when available, a new config1 bit is added for userspace to indicate it wants userspace counter access. This bit allows the kernel to decide if chaining should be disabled and chaining and userspace access