Re: [PATCH v6 1/3] PCI: rockchip: Add support for pcie wake irq

2017-10-19 Thread jeffy
Hi guys, On 10/18/2017 09:29 PM, Bjorn Helgaas wrote: > >I guess it could work to look into pci_create_root_bus(), and >do something like the following? > >if (IS_ENABLED(CONFIG_OF) && parent && parent->of_node) >... do OF parsing for generic features like WAKE# ... That's exact

Re: [PATCH v6 1/3] PCI: rockchip: Add support for pcie wake irq

2017-10-18 Thread Bjorn Helgaas
On Tue, Oct 17, 2017 at 06:03:14PM -0700, Brian Norris wrote: > On Mon, Oct 16, 2017 at 03:03:50PM -0500, Bjorn Helgaas wrote: > > On Sat, Oct 14, 2017 at 03:50:56AM +0800, Jeffy Chen wrote: > > > Add support for PCIE_WAKE pin in rockchip pcie driver. > > > > > > Signed-off-by: Jeffy Chen > > > -

Re: [PATCH v6 1/3] PCI: rockchip: Add support for pcie wake irq

2017-10-17 Thread Brian Norris
On Mon, Oct 16, 2017 at 03:03:50PM -0500, Bjorn Helgaas wrote: > On Sat, Oct 14, 2017 at 03:50:56AM +0800, Jeffy Chen wrote: > > Add support for PCIE_WAKE pin in rockchip pcie driver. > > > > Signed-off-by: Jeffy Chen > > --- > > > > Changes in v6: > > Fix device_init_wake error handling, and ad

Re: [PATCH v6 1/3] PCI: rockchip: Add support for pcie wake irq

2017-10-16 Thread Bjorn Helgaas
On Sat, Oct 14, 2017 at 03:50:56AM +0800, Jeffy Chen wrote: > Add support for PCIE_WAKE pin in rockchip pcie driver. > > Signed-off-by: Jeffy Chen > --- > > Changes in v6: > Fix device_init_wake error handling, and add some comments. > > Changes in v5: > Rebase > > Changes in v3: > Fix error h