Re: [PATCH v6 3/5] test: add new driver_data load tester

2017-05-19 Thread Luis R. Rodriguez
On Wed, May 17, 2017 at 05:45:22PM -0500, Li, Yi wrote: > hi Luis > > > On 5/11/2017 12:11 PM, Luis R. Rodriguez wrote: > > On Thu, May 11, 2017 at 07:46:27PM +0900, AKASHI Takahiro wrote: > > > Luis, > > > > > > On Fri, Apr 28, 2017 at 03:45:35AM +0200, Luis R. Rodriguez wrote: > > > > > > +To

Re: [PATCH v6 3/5] test: add new driver_data load tester

2017-05-17 Thread Li, Yi
hi Luis On 5/11/2017 12:11 PM, Luis R. Rodriguez wrote: On Thu, May 11, 2017 at 07:46:27PM +0900, AKASHI Takahiro wrote: Luis, On Fri, Apr 28, 2017 at 03:45:35AM +0200, Luis R. Rodriguez wrote: +To test an async call one could do:: + +echo anything > /lib/firmware/test-driver_data.bi

Re: [PATCH v6 3/5] test: add new driver_data load tester

2017-05-17 Thread Luis R. Rodriguez
On Wed, May 17, 2017 at 06:08:36PM +0900, AKASHI Takahiro wrote: > On Fri, May 12, 2017 at 05:59:23PM +0200, Luis R. Rodriguez wrote: > > On Fri, May 12, 2017 at 09:28:47AM +0900, AKASHI Takahiro wrote: > > > On Thu, May 11, 2017 at 11:32:30AM -0700, Luis R. Rodriguez wrote: > > > > On Thu, May 11,

Re: [PATCH v6 3/5] test: add new driver_data load tester

2017-05-17 Thread AKASHI Takahiro
On Fri, May 12, 2017 at 05:59:23PM +0200, Luis R. Rodriguez wrote: > On Fri, May 12, 2017 at 09:28:47AM +0900, AKASHI Takahiro wrote: > > On Thu, May 11, 2017 at 11:32:30AM -0700, Luis R. Rodriguez wrote: > > > On Thu, May 11, 2017 at 11:26 AM, Luis R. Rodriguez > > > wrote: > > > > > > > > It wo

Re: [PATCH v6 3/5] test: add new driver_data load tester

2017-05-13 Thread Luis R. Rodriguez
On Fri, May 12, 2017 at 05:52:18PM +0200, Luis R. Rodriguez wrote: > On Fri, May 12, 2017 at 09:20:24AM +0900, AKASHI Takahiro wrote: > > On Thu, May 11, 2017 at 08:26:29PM +0200, Luis R. Rodriguez wrote: > > > On Thu, May 11, 2017 at 07:46:27PM +0900, AKASHI Takahiro wrote: > > > > On Fri, Apr 28,

Re: [PATCH v6 3/5] test: add new driver_data load tester

2017-05-12 Thread Luis R. Rodriguez
On Fri, May 12, 2017 at 09:28:47AM +0900, AKASHI Takahiro wrote: > On Thu, May 11, 2017 at 11:32:30AM -0700, Luis R. Rodriguez wrote: > > On Thu, May 11, 2017 at 11:26 AM, Luis R. Rodriguez wrote: > > > > > > It would seems to make sense to me to only need to verify files when read > > > for the f

Re: [PATCH v6 3/5] test: add new driver_data load tester

2017-05-12 Thread Luis R. Rodriguez
On Fri, May 12, 2017 at 09:20:24AM +0900, AKASHI Takahiro wrote: > On Thu, May 11, 2017 at 08:26:29PM +0200, Luis R. Rodriguez wrote: > > On Thu, May 11, 2017 at 07:46:27PM +0900, AKASHI Takahiro wrote: > > > On Fri, Apr 28, 2017 at 03:45:35AM +0200, Luis R. Rodriguez wrote: > > > > > > diff --git

Re: [PATCH v6 3/5] test: add new driver_data load tester

2017-05-11 Thread AKASHI Takahiro
On Thu, May 11, 2017 at 11:32:30AM -0700, Luis R. Rodriguez wrote: > On Thu, May 11, 2017 at 11:26 AM, Luis R. Rodriguez wrote: > > > > It would seems to make sense to me to only need to verify files when read > > for the first time, once its cache I don't see why we would re-verify them ? > > To

Re: [PATCH v6 3/5] test: add new driver_data load tester

2017-05-11 Thread AKASHI Takahiro
On Thu, May 11, 2017 at 08:26:29PM +0200, Luis R. Rodriguez wrote: > On Thu, May 11, 2017 at 07:46:27PM +0900, AKASHI Takahiro wrote: > > On Fri, Apr 28, 2017 at 03:45:35AM +0200, Luis R. Rodriguez wrote: > > > > > diff --git a/tools/testing/selftests/firmware/driver_data.sh > > > > > b/tools/test

Re: [PATCH v6 3/5] test: add new driver_data load tester

2017-05-11 Thread Luis R. Rodriguez
On Thu, May 11, 2017 at 11:26 AM, Luis R. Rodriguez wrote: > > It would seems to make sense to me to only need to verify files when read > for the first time, once its cache I don't see why we would re-verify them ? To be clear, the fw cache feature reads the files from the fs prior to suspend, a

Re: [PATCH v6 3/5] test: add new driver_data load tester

2017-05-11 Thread Luis R. Rodriguez
On Thu, May 11, 2017 at 07:46:27PM +0900, AKASHI Takahiro wrote: > On Fri, Apr 28, 2017 at 03:45:35AM +0200, Luis R. Rodriguez wrote: > > > > diff --git a/tools/testing/selftests/firmware/driver_data.sh > > > > b/tools/testing/selftests/firmware/driver_data.sh > > ... > > > > > > +TEST_NAME="driv

Re: [PATCH v6 3/5] test: add new driver_data load tester

2017-05-11 Thread Luis R. Rodriguez
On Thu, May 11, 2017 at 07:46:27PM +0900, AKASHI Takahiro wrote: > On Fri, Apr 28, 2017 at 03:45:35AM +0200, Luis R. Rodriguez wrote: > > > > diff --git a/lib/test_driver_data.c b/lib/test_driver_data.c > > > > new file mode 100644 > > > > index ..11175a3b9f0a > > > > --- /dev/null > >

Re: [PATCH v6 3/5] test: add new driver_data load tester

2017-05-11 Thread Luis R. Rodriguez
On Thu, May 11, 2017 at 07:46:27PM +0900, AKASHI Takahiro wrote: > Luis, > > On Fri, Apr 28, 2017 at 03:45:35AM +0200, Luis R. Rodriguez wrote: > > > > +To test an async call one could do:: > > > > + > > > > +echo anything > /lib/firmware/test-driver_data.bin > > > > > > Your current shel

Re: [PATCH v6 3/5] test: add new driver_data load tester

2017-05-11 Thread AKASHI Takahiro
Luis, On Fri, Apr 28, 2017 at 03:45:35AM +0200, Luis R. Rodriguez wrote: > > > +To test an async call one could do:: > > > + > > > +echo anything > /lib/firmware/test-driver_data.bin > > > > Your current shell script doesn't search for the firmware in > > /lib/firmware unless you explicit

Re: [PATCH v6 3/5] test: add new driver_data load tester

2017-04-27 Thread Luis R. Rodriguez
On Tue, Apr 11, 2017 at 05:32:52PM +0900, AKASHI Takahiro wrote: > On Wed, Mar 29, 2017 at 08:25:12PM -0700, Luis R. Rodriguez wrote: > > This adds a load tester driver test_driver_data a for the new extensible > > driver_data loader API, part of firmware_class. This test driver enables > > you to

Re: [PATCH v6 3/5] test: add new driver_data load tester

2017-04-11 Thread AKASHI Takahiro
On Wed, Mar 29, 2017 at 08:25:12PM -0700, Luis R. Rodriguez wrote: > This adds a load tester driver test_driver_data a for the new extensible > driver_data loader API, part of firmware_class. This test driver enables > you to build your tests in userspace by exposing knobs of the exported > API to