Re: [PATCH v6 3/9] docs: Add Generic Counter interface documentation

2018-05-25 Thread William Breathitt Gray
On Fri, May 25, 2018 at 11:26:11AM +0200, Fabrice Gasnier wrote: >On 05/22/2018 07:08 PM, Jonathan Cameron wrote: > +* Quadrature x2 Rising: > + Rising edges on either quadrature pair signals updates the respective > + count. Quadrature encoding determines the direction. This o

Re: [PATCH v6 3/9] docs: Add Generic Counter interface documentation

2018-05-25 Thread Fabrice Gasnier
On 05/22/2018 07:08 PM, Jonathan Cameron wrote: +* Quadrature x2 Rising: + Rising edges on either quadrature pair signals updates the respective + count. Quadrature encoding determines the direction. >>> This one I've never met. Really? There are devices who do this form >>> of

Re: [PATCH v6 3/9] docs: Add Generic Counter interface documentation

2018-05-22 Thread Jonathan Cameron
... > >> + > >> +COUNT > >> +- > >> +A Count represents the count data for a set of Signals. The Generic > >> +Counter interface provides the following available count data types: > >> + > >> +* COUNT_POSITION_UNSIGNED: > >> + Unsigned integer value representing position. > >> + > >> +* COUNT_

Re: [PATCH v6 3/9] docs: Add Generic Counter interface documentation

2018-05-21 Thread William Breathitt Gray
On Sun, May 20, 2018 at 04:31:09PM +0100, Jonathan Cameron wrote: >On Wed, 16 May 2018 13:51:06 -0400 >William Breathitt Gray wrote: > >> This patch adds high-level documentation about the Generic Counter >> interface. >> >> Signed-off-by: William Breathitt Gray > >Various comments inline. I've

Re: [PATCH v6 3/9] docs: Add Generic Counter interface documentation

2018-05-20 Thread Jonathan Cameron
On Wed, 16 May 2018 13:51:06 -0400 William Breathitt Gray wrote: > This patch adds high-level documentation about the Generic Counter > interface. > > Signed-off-by: William Breathitt Gray Various comments inline. I've been doing a lot long reviews recently (outside of the kernel world) and k

Re: [PATCH v6 3/9] docs: Add Generic Counter interface documentation

2018-05-19 Thread kbuild test robot
Hi William, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.17-rc5 next-20180517] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linu