Re: [PATCH v6 4/4] kdb: Switch to use safer dbg_io_ops over console APIs

2020-06-26 Thread Greg KH
On Fri, Jun 26, 2020 at 01:13:48PM +0100, Daniel Thompson wrote: > Hi Greg > > This patch touches some kgdb related code in both serial and usb trees. > > Any objections to my queuing this via the kgdb tree? > > After testing I've concluded that this, and its friends (which only > touch kgdb), f

Re: [PATCH v6 4/4] kdb: Switch to use safer dbg_io_ops over console APIs

2020-06-26 Thread Daniel Thompson
Hi Greg This patch touches some kgdb related code in both serial and usb trees. Any objections to my queuing this via the kgdb tree? After testing I've concluded that this, and its friends (which only touch kgdb), fix enough problems that I plan to queue it for v5.8. Daniel. On Thu, Jun 04,

Re: [PATCH v6 4/4] kdb: Switch to use safer dbg_io_ops over console APIs

2020-06-05 Thread Petr Mladek
On Thu 2020-06-04 15:31:19, Sumit Garg wrote: > In kgdb context, calling console handlers aren't safe due to locks used > in those handlers which could in turn lead to a deadlock. Although, using > oops_in_progress increases the chance to bypass locks in most console > handlers but it might not be

Re: [PATCH v6 4/4] kdb: Switch to use safer dbg_io_ops over console APIs

2020-06-04 Thread Doug Anderson
Hi, On Thu, Jun 4, 2020 at 3:02 AM Sumit Garg wrote: > > @@ -433,7 +432,8 @@ static int kgdboc_earlycon_get_char(void) > { > char c; > > - if (!earlycon->read(earlycon, &c, 1)) > + if (!kgdboc_earlycon_io_ops.cons->read(kgdboc_earlycon_io_ops.cons, > +