Re: [PATCH v6 4/6] mfd: Add hi6421 PMIC core driver

2014-08-26 Thread Lee Jones
On Mon, 25 Aug 2014, Guodong Xu wrote: > On 08/20/2014 04:09 PM, Lee Jones wrote: > > On Mon, 18 Aug 2014, Guodong Xu wrote: > >> This adds driver to support HiSilicon Hi6421 PMIC. Hi6421 includes multi- > >> functions, such as regulators, codec, ADCs, Coulomb counter, etc. > >> This driver include

Re: [PATCH v6 4/6] mfd: Add hi6421 PMIC core driver

2014-08-25 Thread Guodong Xu
Hi, Lee Thanks. I added for most of your comments. Some items, I have a different understanding. I added in below. On 08/20/2014 04:09 PM, Lee Jones wrote: > On Mon, 18 Aug 2014, Guodong Xu wrote: >> This adds driver to support HiSilicon Hi6421 PMIC. Hi6421 includes multi- >> functions, such as

Re: [PATCH v6 4/6] mfd: Add hi6421 PMIC core driver

2014-08-20 Thread Lee Jones
On Mon, 18 Aug 2014, Guodong Xu wrote: > This adds driver to support HiSilicon Hi6421 PMIC. Hi6421 includes multi- > functions, such as regulators, codec, ADCs, Coulomb counter, etc. > This driver includes core APIs _only_. > > Drivers for individul components, like voltage regulators, are > imple

Re: [PATCH v6 4/6] mfd: Add hi6421 PMIC core driver

2014-08-18 Thread Mark Brown
On Mon, Aug 18, 2014 at 09:09:14PM +0800, Guodong Xu wrote: > This adds driver to support HiSilicon Hi6421 PMIC. Hi6421 includes multi- > functions, such as regulators, codec, ADCs, Coulomb counter, etc. > This driver includes core APIs _only_. Please don't resend already applied patches, if there