Hi Marcel,
> From: Marcel Holtmann [mailto:mar...@holtmann.org]
> Sent: Friday, April 22, 2016 6:19 PM
> To: Amitkumar Karwar
> Cc: Linux Bluetooth; LKML; Ganapathi Bhat; Cathy Luo
> Subject: Re: [PATCH v7] Bluetooth: hci_uart: Support firmware download
> for Marvell
Hi Marcel,
> From: Marcel Holtmann [mailto:mar...@holtmann.org]
> Sent: Friday, April 22, 2016 6:19 PM
> To: Amitkumar Karwar
> Cc: Linux Bluetooth; LKML; Ganapathi Bhat; Cathy Luo
> Subject: Re: [PATCH v7] Bluetooth: hci_uart: Support firmware download
> for Marvell
Hi Amitkumar,
+
+static int mrvl_setup(struct hci_uart *hu) {
+ struct mrvl_data *mrvl = hu->priv;
+
+ mrvl_init_fw_data(hu);
+ set_bit(HCI_UART_DNLD_FW, &mrvl->flags);
+
+ return hci_uart_dnld_fw(hu);
+}
>>>
>>> So this is clearly the wrong spot.
Hi Marcel,
>
> > > +
> > > +static int mrvl_setup(struct hci_uart *hu) {
> > > + struct mrvl_data *mrvl = hu->priv;
> > > +
> > > + mrvl_init_fw_data(hu);
> > > + set_bit(HCI_UART_DNLD_FW, &mrvl->flags);
> > > +
> > > + return hci_uart_dnld_fw(hu);
> > > +}
> >
> > So this is clearly the wrong sp
Hi Amitkumar,
> Thanks for your review.
> We will address these comments in updated version.
>
>>> +
>>> +/* Receive data */
>>> +static int mrvl_recv(struct hci_uart *hu, const void *data, int
>>> +count) {
>>> + struct mrvl_data *mrvl = hu->priv;
>>> +
>>> + if (test_bit(HCI_UART_DNLD_FW, &
Hi Marcel,
Thanks for your review.
We will address these comments in updated version.
> > +
> > +/* Receive data */
> > +static int mrvl_recv(struct hci_uart *hu, const void *data, int
> > +count) {
> > + struct mrvl_data *mrvl = hu->priv;
> > +
> > + if (test_bit(HCI_UART_DNLD_FW, &mrvl->fla
Hi Amitkumar,
> This patch implement firmware download feature for
> Marvell Bluetooth devices. If firmware is already
> downloaded, it will skip downloading.
>
> Signed-off-by: Ganapathi Bhat
> Signed-off-by: Amitkumar Karwar
> ---
> v2: Fixed compilation warning reported by kbuild test robot
7 matches
Mail list logo
