Re: [PATCH v7 06/13] slimbus: Add messaging APIs to slimbus framework

2017-11-27 Thread Srinivas Kandagatla
On 27/11/17 05:56, Vinod Koul wrote: On Mon, Nov 20, 2017 at 06:47:52AM +, Srinivas Kandagatla wrote: + * -ENOTCONN: If the transmitted message was not ACKed by destination + * device. I am preferring ENODATA in SDW for this case, as Slaves didnt respond or ACK. Isn't that a ti

Re: [PATCH v7 06/13] slimbus: Add messaging APIs to slimbus framework

2017-11-26 Thread Vinod Koul
On Mon, Nov 20, 2017 at 06:47:52AM +, Srinivas Kandagatla wrote: > >>+ * -ENOTCONN: If the transmitted message was not ACKed by destination > >>+ * device. > > > >I am preferring ENODATA in SDW for this case, as Slaves didnt respond or > >ACK. > Isn't that a timeout error then. > > ENODATA is

Re: [PATCH v7 06/13] slimbus: Add messaging APIs to slimbus framework

2017-11-19 Thread Srinivas Kandagatla
thanks for the comments, On 17/11/17 07:48, Vinod Koul wrote: On Wed, Nov 15, 2017 at 02:10:36PM +, srinivas.kandaga...@linaro.org wrote: +void slim_msg_response(struct slim_controller *ctrl, u8 *reply, u8 tid, u8 len) +{ + struct slim_msg_txn *txn; + struct slim_val_inf *msg;

Re: [PATCH v7 06/13] slimbus: Add messaging APIs to slimbus framework

2017-11-16 Thread Vinod Koul
On Wed, Nov 15, 2017 at 02:10:36PM +, srinivas.kandaga...@linaro.org wrote: > +void slim_msg_response(struct slim_controller *ctrl, u8 *reply, u8 tid, u8 > len) > +{ > + struct slim_msg_txn *txn; > + struct slim_val_inf *msg; > + unsigned long flags; > + > + spin_lock_irqsave(