Re: [PATCH v7 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-08-02 Thread Wu, Songjun
On 8/2/2016 15:32, Hans Verkuil wrote: On 08/02/2016 08:20 AM, Wu, Songjun wrote: +static unsigned int sensor_preferred = 1; +module_param(sensor_preferred, uint, S_IRUGO|S_IWUSR); +MODULE_PARM_DESC(sensor_preferred, +"Sensor is preferred to output the specified format (1-on

Re: [PATCH v7 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-08-02 Thread Hans Verkuil
On 08/02/2016 08:20 AM, Wu, Songjun wrote: >>> +static unsigned int sensor_preferred = 1; >>> +module_param(sensor_preferred, uint, S_IRUGO|S_IWUSR); >>> +MODULE_PARM_DESC(sensor_preferred, >>> +"Sensor is preferred to output the specified format (1-on >>> 0-off) default 1"); >> >> I

Re: [PATCH v7 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-08-01 Thread Wu, Songjun
On 8/1/2016 17:47, Hans Verkuil wrote: Hi Songjun, Some more comments below. Except for one in the open/release functions it's all small things. On 07/29/2016 09:54 AM, Songjun Wu wrote: Add driver for the Image Sensor Controller. It manages incoming data from a parallel based CMOS/CCD senso

Re: [PATCH v7 1/2] [media] atmel-isc: add the Image Sensor Controller code

2016-08-01 Thread Hans Verkuil
Hi Songjun, Some more comments below. Except for one in the open/release functions it's all small things. On 07/29/2016 09:54 AM, Songjun Wu wrote: > Add driver for the Image Sensor Controller. It manages > incoming data from a parallel based CMOS/CCD sensor. > It has an internal image processor,