Re: [PATCH v7 1/5] leds: core: add generic support for RGB LED's

2016-03-11 Thread Heiner Kallweit
Am 11.03.2016 um 09:38 schrieb Jacek Anaszewski: > Hi Heiner, > > Thanks for the updated set. I've renamed the feature to RGB LED class > and pushed out to devel branch of linux-leds.git. It will sit there > till the end of the upcoming merge window. There have been some > uncertainties raised rel

Re: [PATCH v7 1/5] leds: core: add generic support for RGB LED's

2016-03-11 Thread Jacek Anaszewski
Hi Heiner, Thanks for the updated set. I've renamed the feature to RGB LED class and pushed out to devel branch of linux-leds.git. It will sit there till the end of the upcoming merge window. There have been some uncertainties raised related to overloading brightness syntax. so let's better have

Re: [PATCH v7 1/5] leds: core: add generic support for RGB LED's

2016-03-07 Thread Jacek Anaszewski
Hi Karl, On 03/06/2016 09:55 PM, Karl Palsson wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Heiner Kallweit wrote: Add generic support for RGB LED's. Basic idea is to use enum led_brightness also for the hue and saturation color components.This allows to implement the color extension

Re: [PATCH v7 1/5] leds: core: add generic support for RGB LED's

2016-03-06 Thread Karl Palsson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > > I admit I hadn't seen this earlier, and I didn't spend all day > > looking at previous attempts, but what's the motivation for > > putting all this overloaded syntax into the "brightness" file? I > > thought the point was to have a single value in

Re: [PATCH v7 1/5] leds: core: add generic support for RGB LED's

2016-03-06 Thread Heiner Kallweit
Am 06.03.2016 um 21:55 schrieb Karl Palsson: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Heiner Kallweit wrote: >> Add generic support for RGB LED's. >> >> Basic idea is to use enum led_brightness also for the hue and >> saturation color components.This allows to implement the color >>

Re: [PATCH v7 1/5] leds: core: add generic support for RGB LED's

2016-03-06 Thread Karl Palsson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Heiner Kallweit wrote: > Add generic support for RGB LED's. > > Basic idea is to use enum led_brightness also for the hue and > saturation color components.This allows to implement the color > extension w/o changes to struct led_classdev. > > Select