Re: [PATCH v7 1/9] firmware: arm_scmi: Add notification protocol-registration

2020-05-13 Thread Cristian Marussi
On Wed, May 13, 2020 at 05:46:13PM +0100, Dave Martin wrote: > On Mon, May 11, 2020 at 11:04:03PM +0100, Cristian Marussi wrote: > > Hi Dave > > > > thanks for the review first of all. > > [snip] > > > > First of all the enabled flag does not probably belong to this commit > > properly; > > he

Re: [PATCH v7 1/9] firmware: arm_scmi: Add notification protocol-registration

2020-05-13 Thread Dave Martin
On Mon, May 11, 2020 at 11:04:03PM +0100, Cristian Marussi wrote: > Hi Dave > > thanks for the review first of all. > > On Wed, May 06, 2020 at 04:25:50PM +0100, Dave Martin wrote: > > On Mon, May 04, 2020 at 05:38:47PM +0100, Cristian Marussi wrote: > > > Add core SCMI Notifications protocol-reg

Re: [PATCH v7 1/9] firmware: arm_scmi: Add notification protocol-registration

2020-05-12 Thread Sudeep Holla
On Tue, May 12, 2020 at 06:00:20PM +0100, Cristian Marussi wrote: > On Mon, May 11, 2020 at 11:04:03PM +0100, Cristian Marussi wrote: > > Hi Dave > > > > thanks for the review first of all. > > > [snip] > > > > I'm not sure about scmi_notification_exit() (see below). > [snip] > > > > +/** > > > > +

Re: [PATCH v7 1/9] firmware: arm_scmi: Add notification protocol-registration

2020-05-12 Thread Cristian Marussi
On Mon, May 11, 2020 at 11:04:03PM +0100, Cristian Marussi wrote: > Hi Dave > > thanks for the review first of all. > [snip] > > I'm not sure about scmi_notification_exit() (see below). [snip] > > > +/** > > > + * scmi_notification_exit() - Shutdown and clean Notification core > > > + * @handle

Re: [PATCH v7 1/9] firmware: arm_scmi: Add notification protocol-registration

2020-05-11 Thread Cristian Marussi
Hi Dave thanks for the review first of all. On Wed, May 06, 2020 at 04:25:50PM +0100, Dave Martin wrote: > On Mon, May 04, 2020 at 05:38:47PM +0100, Cristian Marussi wrote: > > Add core SCMI Notifications protocol-registration support: allow protocols > > to register their own set of supported ev

Re: [PATCH v7 1/9] firmware: arm_scmi: Add notification protocol-registration

2020-05-06 Thread Dave Martin
On Mon, May 04, 2020 at 05:38:47PM +0100, Cristian Marussi wrote: > Add core SCMI Notifications protocol-registration support: allow protocols > to register their own set of supported events, during their initialization > phase. Notification core can track multiple platform instances by their > han