Re: [PATCH v7 2/2] ASoC: codecs: add wsa881x amplifier support

2019-10-10 Thread Srinivas Kandagatla
On 10/10/2019 14:23, Mark Brown wrote: On Thu, Oct 10, 2019 at 10:28:04AM +0100, Srinivas Kandagatla wrote: On 09/10/2019 17:35, Mark Brown wrote: On Wed, Oct 09, 2019 at 09:51:08AM +0100, Srinivas Kandagatla wrote: +static const u8 wsa881x_reg_readable[WSA881X_CACHE_SIZE] = { +static bo

Re: [PATCH v7 2/2] ASoC: codecs: add wsa881x amplifier support

2019-10-10 Thread Mark Brown
On Thu, Oct 10, 2019 at 10:28:04AM +0100, Srinivas Kandagatla wrote: > On 09/10/2019 17:35, Mark Brown wrote: > > On Wed, Oct 09, 2019 at 09:51:08AM +0100, Srinivas Kandagatla wrote: > > > +static const u8 wsa881x_reg_readable[WSA881X_CACHE_SIZE] = { > > > +static bool wsa881x_readable_register(st

Re: [PATCH v7 2/2] ASoC: codecs: add wsa881x amplifier support

2019-10-10 Thread Srinivas Kandagatla
Thanks Mark for taking time to review this patch. On 09/10/2019 17:35, Mark Brown wrote: On Wed, Oct 09, 2019 at 09:51:08AM +0100, Srinivas Kandagatla wrote: +static const u8 wsa881x_reg_readable[WSA881X_CACHE_SIZE] = { +static bool wsa881x_readable_register(struct device *dev, unsigned int

Re: [PATCH v7 2/2] ASoC: codecs: add wsa881x amplifier support

2019-10-09 Thread Mark Brown
On Wed, Oct 09, 2019 at 09:51:08AM +0100, Srinivas Kandagatla wrote: > +static const u8 wsa881x_reg_readable[WSA881X_CACHE_SIZE] = { > +static bool wsa881x_readable_register(struct device *dev, unsigned int reg) > +{ > + return wsa881x_reg_readable[reg]; u There's no bounds check and that arr