Re: [PATCH v7 2/6] pci: OF: Fix the conversion of IO ranges into IO resources.

2014-03-17 Thread Liviu Dudau
On Fri, Mar 14, 2014 at 07:16:10PM +, Arnd Bergmann wrote: > On Friday 14 March 2014, Liviu Dudau wrote: > > On Fri, Mar 14, 2014 at 06:46:23PM +, Arnd Bergmann wrote: > > > On Friday 14 March 2014, Liviu Dudau wrote: > > > > > > > +int of_pci_range_to_resource(struct of_pci_range *range,

Re: [PATCH v7 2/6] pci: OF: Fix the conversion of IO ranges into IO resources.

2014-03-14 Thread Arnd Bergmann
On Friday 14 March 2014, Liviu Dudau wrote: > On Fri, Mar 14, 2014 at 06:46:23PM +, Arnd Bergmann wrote: > > On Friday 14 March 2014, Liviu Dudau wrote: > > > > > +int of_pci_range_to_resource(struct of_pci_range *range, > > > + struct device_node *np, struct resource *res) > > > +{ > >

Re: [PATCH v7 2/6] pci: OF: Fix the conversion of IO ranges into IO resources.

2014-03-14 Thread Liviu Dudau
On Fri, Mar 14, 2014 at 06:46:23PM +, Arnd Bergmann wrote: > On Friday 14 March 2014, Liviu Dudau wrote: > > You are right, that was lazy of me. What about this version? > > Yes, that seems better. Thanks for fixing it up. > > But back to the more important question that I realized we have >

Re: [PATCH v7 2/6] pci: OF: Fix the conversion of IO ranges into IO resources.

2014-03-14 Thread Arnd Bergmann
On Friday 14 March 2014, Liviu Dudau wrote: > You are right, that was lazy of me. What about this version? Yes, that seems better. Thanks for fixing it up. But back to the more important question that I realized we have not resolved yet: You now have two completely independent allocation functio

Re: [PATCH v7 2/6] pci: OF: Fix the conversion of IO ranges into IO resources.

2014-03-14 Thread Liviu Dudau
On Fri, Mar 14, 2014 at 05:05:28PM +, Arnd Bergmann wrote: > On Friday 14 March 2014, Liviu Dudau wrote: > > +int of_pci_range_to_resource(struct of_pci_range *range, > > + struct device_node *np, struct resource *res) > > +{ > > + res->flags = range->flags; > > + if (res->fla

Re: [PATCH v7 2/6] pci: OF: Fix the conversion of IO ranges into IO resources.

2014-03-14 Thread Arnd Bergmann
On Friday 14 March 2014, Liviu Dudau wrote: > +int of_pci_range_to_resource(struct of_pci_range *range, > + struct device_node *np, struct resource *res) > +{ > + res->flags = range->flags; > + if (res->flags & IORESOURCE_IO) { > + unsigned long port = -1; > +