Re: [PATCH v7 3/3] drm/fence: add out-fences support

2016-11-09 Thread Daniel Vetter
On Wed, Nov 09, 2016 at 11:39:11AM +0900, Gustavo Padovan wrote: > > On Tue, Nov 08, 2016 at 03:54:50PM +0900, Gustavo Padovan wrote: > > > + if (!access_ok(VERIFY_WRITE, fence_ptr, sizeof(*fence_ptr))) > > > + return -EFAULT; > > > > Same comment about igt coverage I made

Re: [PATCH v7 3/3] drm/fence: add out-fences support

2016-11-08 Thread Gustavo Padovan
2016-11-08 Daniel Vetter : > On Tue, Nov 08, 2016 at 03:54:50PM +0900, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Support DRM out-fences by creating a sync_file with a fence for each CRTC > > that sets the OUT_FENCE_PTR property. > > > > We use the out_fence pointer received in th

Re: [PATCH v7 3/3] drm/fence: add out-fences support

2016-11-08 Thread Brian Starkey
On Tue, Nov 08, 2016 at 03:54:50PM +0900, Gustavo Padovan wrote: From: Gustavo Padovan +static struct dma_fence *get_crtc_fence(struct drm_crtc *crtc, + struct drm_crtc_state *crtc_state) +{ + struct dma_fence *fence; + + fence = kzalloc(sizeof(

Re: [PATCH v7 3/3] drm/fence: add out-fences support

2016-11-08 Thread Daniel Vetter
On Tue, Nov 08, 2016 at 03:54:50PM +0900, Gustavo Padovan wrote: > From: Gustavo Padovan > > Support DRM out-fences by creating a sync_file with a fence for each CRTC > that sets the OUT_FENCE_PTR property. > > We use the out_fence pointer received in the OUT_FENCE_PTR prop to send > the sync_fi