Re: [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT

2015-08-26 Thread Vlastimil Babka
On 08/26/2015 09:20 AM, Michal Hocko wrote: On Tue 25-08-15 15:03:00, Eric B Munson wrote: [...] Would you drop your objections to the VMA flag if I drop the portions of the patch that expose it to userspace? The rework to not use the VMA flag is pretty sizeable and is much more ugly IMO. I kn

Re: [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT

2015-08-26 Thread Michal Hocko
On Tue 25-08-15 15:03:00, Eric B Munson wrote: [...] > Would you drop your objections to the VMA flag if I drop the portions of > the patch that expose it to userspace? > > The rework to not use the VMA flag is pretty sizeable and is much more > ugly IMO. I know that you are not wild about using

Re: [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT

2015-08-25 Thread Eric B Munson
On Tue, 25 Aug 2015, Michal Hocko wrote: > On Tue 25-08-15 10:29:02, Eric B Munson wrote: > > On Tue, 25 Aug 2015, Michal Hocko wrote: > [...] > > > Considering the current behavior I do not thing it would be terrible > > > thing to do what Konstantin was suggesting and populate only the full > >

Re: [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT

2015-08-25 Thread Michal Hocko
On Tue 25-08-15 10:29:02, Eric B Munson wrote: > On Tue, 25 Aug 2015, Michal Hocko wrote: [...] > > Considering the current behavior I do not thing it would be terrible > > thing to do what Konstantin was suggesting and populate only the full > > ranges in a best effort mode (it is done so anyway)

Re: [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT

2015-08-25 Thread Michal Hocko
On Tue 25-08-15 15:55:46, Vlastimil Babka wrote: > On 08/25/2015 03:41 PM, Michal Hocko wrote: [...] > >So what we have as a result is that partially populated ranges are > >preserved and fully populated ones work in the best effort mode the same > >way as they are now. > > > >Does that sound at le

Re: [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT

2015-08-25 Thread Eric B Munson
On Tue, 25 Aug 2015, Michal Hocko wrote: > On Fri 21-08-15 14:31:32, Eric B Munson wrote: > [...] > > I am in the middle of implementing lock on fault this way, but I cannot > > see how we will hanlde mremap of a lock on fault region. Say we have > > the following: > > > > addr = mmap(len, M

Re: [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT

2015-08-25 Thread Konstantin Khlebnikov
On Tue, Aug 25, 2015 at 4:41 PM, Michal Hocko wrote: > On Fri 21-08-15 14:31:32, Eric B Munson wrote: > [...] >> I am in the middle of implementing lock on fault this way, but I cannot >> see how we will hanlde mremap of a lock on fault region. Say we have >> the following: >> >> addr = mmap(

Re: [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT

2015-08-25 Thread Vlastimil Babka
On 08/25/2015 03:41 PM, Michal Hocko wrote: On Fri 21-08-15 14:31:32, Eric B Munson wrote: [...] I am in the middle of implementing lock on fault this way, but I cannot see how we will hanlde mremap of a lock on fault region. Say we have the following: addr = mmap(len, MAP_ANONYMOUS, ...)

Re: [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT

2015-08-25 Thread Michal Hocko
On Fri 21-08-15 14:31:32, Eric B Munson wrote: [...] > I am in the middle of implementing lock on fault this way, but I cannot > see how we will hanlde mremap of a lock on fault region. Say we have > the following: > > addr = mmap(len, MAP_ANONYMOUS, ...); > mlock(addr, len, MLOCK_ONFAULT

Re: [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT

2015-08-24 Thread Eric B Munson
On Mon, 24 Aug 2015, Konstantin Khlebnikov wrote: > On Mon, Aug 24, 2015 at 8:00 PM, Eric B Munson wrote: > > On Mon, 24 Aug 2015, Konstantin Khlebnikov wrote: > > > >> On Mon, Aug 24, 2015 at 6:55 PM, Eric B Munson wrote: > >> > On Mon, 24 Aug 2015, Konstantin Khlebnikov wrote: > >> > > >> >> O

Re: [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT

2015-08-24 Thread Konstantin Khlebnikov
On Mon, Aug 24, 2015 at 8:00 PM, Eric B Munson wrote: > On Mon, 24 Aug 2015, Konstantin Khlebnikov wrote: > >> On Mon, Aug 24, 2015 at 6:55 PM, Eric B Munson wrote: >> > On Mon, 24 Aug 2015, Konstantin Khlebnikov wrote: >> > >> >> On Mon, Aug 24, 2015 at 6:09 PM, Eric B Munson wrote: >> >> > On

Re: [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT

2015-08-24 Thread Eric B Munson
On Mon, 24 Aug 2015, Konstantin Khlebnikov wrote: > On Mon, Aug 24, 2015 at 6:55 PM, Eric B Munson wrote: > > On Mon, 24 Aug 2015, Konstantin Khlebnikov wrote: > > > >> On Mon, Aug 24, 2015 at 6:09 PM, Eric B Munson wrote: > >> > On Mon, 24 Aug 2015, Vlastimil Babka wrote: > >> > > >> >> On 08/2

Re: [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT

2015-08-24 Thread Konstantin Khlebnikov
On Mon, Aug 24, 2015 at 6:55 PM, Eric B Munson wrote: > On Mon, 24 Aug 2015, Konstantin Khlebnikov wrote: > >> On Mon, Aug 24, 2015 at 6:09 PM, Eric B Munson wrote: >> > On Mon, 24 Aug 2015, Vlastimil Babka wrote: >> > >> >> On 08/24/2015 03:50 PM, Konstantin Khlebnikov wrote: >> >> >On Mon, Aug

Re: [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT

2015-08-24 Thread Eric B Munson
On Mon, 24 Aug 2015, Konstantin Khlebnikov wrote: > On Mon, Aug 24, 2015 at 6:09 PM, Eric B Munson wrote: > > On Mon, 24 Aug 2015, Vlastimil Babka wrote: > > > >> On 08/24/2015 03:50 PM, Konstantin Khlebnikov wrote: > >> >On Mon, Aug 24, 2015 at 4:30 PM, Vlastimil Babka wrote: > >> >>On 08/24/20

Re: [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT

2015-08-24 Thread Konstantin Khlebnikov
On Mon, Aug 24, 2015 at 6:09 PM, Eric B Munson wrote: > On Mon, 24 Aug 2015, Vlastimil Babka wrote: > >> On 08/24/2015 03:50 PM, Konstantin Khlebnikov wrote: >> >On Mon, Aug 24, 2015 at 4:30 PM, Vlastimil Babka wrote: >> >>On 08/24/2015 12:17 PM, Konstantin Khlebnikov wrote: >> >> >> >>

Re: [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT

2015-08-24 Thread Eric B Munson
On Mon, 24 Aug 2015, Vlastimil Babka wrote: > On 08/24/2015 03:50 PM, Konstantin Khlebnikov wrote: > >On Mon, Aug 24, 2015 at 4:30 PM, Vlastimil Babka wrote: > >>On 08/24/2015 12:17 PM, Konstantin Khlebnikov wrote: > > > I am in the middle of implementing lock on fault this way, but

Re: [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT

2015-08-24 Thread Vlastimil Babka
On 08/24/2015 03:50 PM, Konstantin Khlebnikov wrote: On Mon, Aug 24, 2015 at 4:30 PM, Vlastimil Babka wrote: On 08/24/2015 12:17 PM, Konstantin Khlebnikov wrote: I am in the middle of implementing lock on fault this way, but I cannot see how we will hanlde mremap of a lock on fault region.

Re: [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT

2015-08-24 Thread Konstantin Khlebnikov
On Mon, Aug 24, 2015 at 4:30 PM, Vlastimil Babka wrote: > On 08/24/2015 12:17 PM, Konstantin Khlebnikov wrote: >>> >>> >>> I am in the middle of implementing lock on fault this way, but I cannot >>> see how we will hanlde mremap of a lock on fault region. Say we have >>> the following: >>> >>>

Re: [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT

2015-08-24 Thread Vlastimil Babka
On 08/24/2015 12:17 PM, Konstantin Khlebnikov wrote: I am in the middle of implementing lock on fault this way, but I cannot see how we will hanlde mremap of a lock on fault region. Say we have the following: addr = mmap(len, MAP_ANONYMOUS, ...); mlock(addr, len, MLOCK_ONFAULT);

Re: [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT

2015-08-24 Thread Konstantin Khlebnikov
On Fri, Aug 21, 2015 at 9:31 PM, Eric B Munson wrote: > On Fri, 21 Aug 2015, Michal Hocko wrote: > >> On Thu 20-08-15 13:03:09, Eric B Munson wrote: >> > On Thu, 20 Aug 2015, Michal Hocko wrote: >> > >> > > On Wed 19-08-15 17:33:45, Eric B Munson wrote: >> > > [...] >> > > > The group which asked

Re: [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT

2015-08-21 Thread Eric B Munson
On Fri, 21 Aug 2015, Michal Hocko wrote: > On Thu 20-08-15 13:03:09, Eric B Munson wrote: > > On Thu, 20 Aug 2015, Michal Hocko wrote: > > > > > On Wed 19-08-15 17:33:45, Eric B Munson wrote: > > > [...] > > > > The group which asked for this feature here > > > > wants the ability to distinguish

Re: [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT

2015-08-21 Thread Michal Hocko
On Thu 20-08-15 13:03:09, Eric B Munson wrote: > On Thu, 20 Aug 2015, Michal Hocko wrote: > > > On Wed 19-08-15 17:33:45, Eric B Munson wrote: > > [...] > > > The group which asked for this feature here > > > wants the ability to distinguish between LOCKED and LOCKONFAULT regions > > > and without

Re: [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT

2015-08-20 Thread Eric B Munson
On Thu, 20 Aug 2015, Michal Hocko wrote: > On Wed 19-08-15 17:33:45, Eric B Munson wrote: > [...] > > The group which asked for this feature here > > wants the ability to distinguish between LOCKED and LOCKONFAULT regions > > and without the VMA flag there isn't a way to do that. > > Could you be

Re: [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT

2015-08-20 Thread Michal Hocko
On Wed 19-08-15 17:33:45, Eric B Munson wrote: [...] > The group which asked for this feature here > wants the ability to distinguish between LOCKED and LOCKONFAULT regions > and without the VMA flag there isn't a way to do that. Could you be more specific on why this is needed? > Do we know that

Re: [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT

2015-08-20 Thread Vlastimil Babka
On 08/19/2015 11:33 PM, Eric B Munson wrote: On Wed, 12 Aug 2015, Michal Hocko wrote: On Sun 09-08-15 01:22:53, Eric B Munson wrote: I do not like this very much to be honest. We have only few bits left there and it seems this is not really necessary. I thought that LOCKONFAULT acts as a modif

Re: [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT

2015-08-19 Thread Eric B Munson
On Wed, 12 Aug 2015, Michal Hocko wrote: > On Sun 09-08-15 01:22:53, Eric B Munson wrote: > > The cost of faulting in all memory to be locked can be very high when > > working with large mappings. If only portions of the mapping will be > > used this can incur a high penalty for locking. > > > >

Re: [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT

2015-08-12 Thread Michal Hocko
On Sun 09-08-15 01:22:53, Eric B Munson wrote: > The cost of faulting in all memory to be locked can be very high when > working with large mappings. If only portions of the mapping will be > used this can incur a high penalty for locking. > > For the example of a large file, this is the usage pa