Re: [PATCH v7 8/9] i2c: rk3x: add i2c support for rk3399 soc

2016-05-06 Thread Doug Anderson
Hi On Fri, May 6, 2016 at 2:32 AM, David.Wu wrote: >> Also (optional): once you do that, there becomes much less of a reason >> to store "t_calc" in "struct rk3x_i2c". Already you're never using >> the "div_low" and "div_high" that you store in the "struct rk3x_i2c". >> Of course, to do that you

Re: [PATCH v7 8/9] i2c: rk3x: add i2c support for rk3399 soc

2016-05-06 Thread David.Wu
Hi Doug, 在 2016/5/6 7:00, Doug Anderson 写道: David, On Wed, May 4, 2016 at 7:36 AM, David Wu wrote: +/** + * Calculate timing values for desired SCL frequency + * + * @clk_rate: I2C input clock rate + * @t: Known I2C timing information + * @t_calc: Caculated rk3x private timings that would be

Re: [PATCH v7 8/9] i2c: rk3x: add i2c support for rk3399 soc

2016-05-05 Thread Doug Anderson
David, On Wed, May 4, 2016 at 7:36 AM, David Wu wrote: > +/** > + * Calculate timing values for desired SCL frequency > + * > + * @clk_rate: I2C input clock rate > + * @t: Known I2C timing information > + * @t_calc: Caculated rk3x private timings that would be written into regs > + > + * Returns: