Re: [PATCH v8 00/23] IB/Verbs: IB Management Helpers

2015-05-13 Thread Michael Wang
On 05/12/2015 10:09 PM, Doug Ledford wrote: [snip] >> >> I had asked for better kdocs for the new helpers so new people can >> understand when and where to use them. >> >> I've not looked at the series at all for the past few postings. > > Michael, please work up an incremental patch to address

Re: [PATCH v8 00/23] IB/Verbs: IB Management Helpers

2015-05-12 Thread Doug Ledford
On Tue, 2015-05-12 at 12:09 -0600, Jason Gunthorpe wrote: > On Mon, May 11, 2015 at 08:27:00PM -0400, Doug Ledford wrote: > > On Mon, 2015-05-11 at 19:49 -0400, ira.weiny wrote: > > > I have run with this series and the only issue I have found is not with > > > this > > > patch set directly. > > >

Re: [PATCH v8 00/23] IB/Verbs: IB Management Helpers

2015-05-12 Thread Jason Gunthorpe
On Mon, May 11, 2015 at 08:27:00PM -0400, Doug Ledford wrote: > On Mon, 2015-05-11 at 19:49 -0400, ira.weiny wrote: > > I have run with this series and the only issue I have found is not with this > > patch set directly. > > > > This patch: > > > > > IB/Verbs: Use management helper rdma_cap_ib_

Re: [PATCH v8 00/23] IB/Verbs: IB Management Helpers

2015-05-12 Thread Michael Wang
On 05/12/2015 04:24 PM, Doug Ledford wrote: [snip] >> >> AFAIK Or was asking to merge the #15~23, and want to reserve the changelog >> meanwhile reply the cover of prev version (I'm still confused on that...), >> I've replied but get no respond yet. >> >> I can make a v9 to merge the #15~#23 if t

Re: [PATCH v8 00/23] IB/Verbs: IB Management Helpers

2015-05-12 Thread Doug Ledford
On Tue, 2015-05-12 at 09:57 +0200, Michael Wang wrote: > > On 05/12/2015 02:27 AM, Doug Ledford wrote: > > On Mon, 2015-05-11 at 19:49 -0400, ira.weiny wrote: > >> I have run with this series and the only issue I have found is not with > >> this > >> patch set directly. > >> > >> This patch: > >>

Re: [PATCH v8 00/23] IB/Verbs: IB Management Helpers

2015-05-12 Thread Michael Wang
On 05/12/2015 01:49 AM, ira.weiny wrote: > I have run with this series and the only issue I have found is not with this > patch set directly. > > This patch: > >> IB/Verbs: Use management helper rdma_cap_ib_mad() > > causes an error when you actually use the port passed from the ib_umad module

Re: [PATCH v8 00/23] IB/Verbs: IB Management Helpers

2015-05-12 Thread Michael Wang
On 05/12/2015 02:27 AM, Doug Ledford wrote: > On Mon, 2015-05-11 at 19:49 -0400, ira.weiny wrote: >> I have run with this series and the only issue I have found is not with this >> patch set directly. >> >> This patch: >> >>> IB/Verbs: Use management helper rdma_cap_ib_mad() >> >> causes an err

Re: [PATCH v8 00/23] IB/Verbs: IB Management Helpers

2015-05-11 Thread Doug Ledford
On Mon, 2015-05-11 at 19:49 -0400, ira.weiny wrote: > I have run with this series and the only issue I have found is not with this > patch set directly. > > This patch: > > > IB/Verbs: Use management helper rdma_cap_ib_mad() > > causes an error when you actually use the port passed from the ib

Re: [PATCH v8 00/23] IB/Verbs: IB Management Helpers

2015-05-11 Thread ira.weiny
I have run with this series and the only issue I have found is not with this patch set directly. This patch: > IB/Verbs: Use management helper rdma_cap_ib_mad() causes an error when you actually use the port passed from the ib_umad module. I have a patch to fix that which I found while trying

Re: [PATCH v8 00/23] IB/Verbs: IB Management Helpers

2015-05-08 Thread Devesh Sharma
Reviewed-by: Devesh Sharma On Tue, May 5, 2015 at 8:10 PM, Michael Wang wrote: > > > On 05/05/2015 04:16 PM, Or Gerlitz wrote: >> On 5/5/2015 3:50 PM, Michael Wang wrote: >>> Since v7: >>>* Thanks to Doug, Ira, Devesh for the testing:-) >>>* Thanks for the comments from or, Doug, Ira, Ja

Re: [PATCH v8 00/23] IB/Verbs: IB Management Helpers

2015-05-05 Thread Or Gerlitz
On 5/5/2015 3:50 PM, Michael Wang wrote: Since v7: * Thanks to Doug, Ira, Devesh for the testing:-) * Thanks for the comments from or, Doug, Ira, Jason:-) Please remind me if anything missed:-P * Use rdma_cap_XX() instead of cap_XX() for readability * Remove CC list in git log fo

Re: [PATCH v8 00/23] IB/Verbs: IB Management Helpers

2015-05-05 Thread Michael Wang
On 05/05/2015 04:16 PM, Or Gerlitz wrote: > On 5/5/2015 3:50 PM, Michael Wang wrote: >> Since v7: >>* Thanks to Doug, Ira, Devesh for the testing:-) >>* Thanks for the comments from or, Doug, Ira, Jason:-) >> Please remind me if anything missed:-P >>* Use rdma_cap_XX() instead of