Re: [PATCH v8 09/10] drivers: qcom: rpmh: add support for batch RPMH request

2018-05-30 Thread Doug Anderson
Hi, On Wed, May 23, 2018 at 6:27 AM, Raju P L S S S N wrote: >>> + break; >> >> >> "break" seems wrong here. You'll end up waiting for the completion, >> then I guess timing out, then returning -ETIMEDOUT? > > > As the loop above break runs for remaining count, completion w

Re: [PATCH v8 09/10] drivers: qcom: rpmh: add support for batch RPMH request

2018-05-23 Thread Raju P L S S S N
Hi, will reply on points other than what Lina has responded. On 5/12/2018 1:49 AM, Doug Anderson wrote: Hi, On Wed, May 9, 2018 at 10:01 AM, Lina Iyer wrote: /** @@ -77,12 +82,14 @@ struct rpmh_request { * @cache: the list of cached requests * @lock: synchronize access to the control

Re: [PATCH v8 09/10] drivers: qcom: rpmh: add support for batch RPMH request

2018-05-15 Thread Doug Anderson
Hi, On Tue, May 15, 2018 at 11:03 AM, Lina Iyer wrote: >>> Also, the bus requests have quite a churn during the course of an >>> usecase. They are setup and invalidated often. >>> It is faster to have them separate and invalidate the whole lot of the >>> batch_cache instead of intertwining them w

Re: [PATCH v8 09/10] drivers: qcom: rpmh: add support for batch RPMH request

2018-05-15 Thread Lina Iyer
On Tue, May 15 2018 at 10:50 -0600, Doug Anderson wrote: Hi, On Tue, May 15, 2018 at 9:23 AM, Lina Iyer wrote: On Tue, May 15 2018 at 09:52 -0600, Doug Anderson wrote: Hi, On Mon, May 14, 2018 at 12:59 PM, Lina Iyer wrote: /** @@ -77,12 +82,14 @@ struct rpmh_request { * @cache: the li

Re: [PATCH v8 09/10] drivers: qcom: rpmh: add support for batch RPMH request

2018-05-15 Thread Doug Anderson
Hi, On Tue, May 15, 2018 at 9:23 AM, Lina Iyer wrote: > On Tue, May 15 2018 at 09:52 -0600, Doug Anderson wrote: >> >> Hi, >> >> On Mon, May 14, 2018 at 12:59 PM, Lina Iyer wrote: >> > /** > @@ -77,12 +82,14 @@ struct rpmh_request { > * @cache: the list of cached requests >

Re: [PATCH v8 09/10] drivers: qcom: rpmh: add support for batch RPMH request

2018-05-15 Thread Lina Iyer
On Tue, May 15 2018 at 09:52 -0600, Doug Anderson wrote: Hi, On Mon, May 14, 2018 at 12:59 PM, Lina Iyer wrote: /** @@ -77,12 +82,14 @@ struct rpmh_request { * @cache: the list of cached requests * @lock: synchronize access to the controller data * @dirty: was the cache updated since f

Re: [PATCH v8 09/10] drivers: qcom: rpmh: add support for batch RPMH request

2018-05-15 Thread Doug Anderson
Hi, On Mon, May 14, 2018 at 12:59 PM, Lina Iyer wrote: >>> /** >>> @@ -77,12 +82,14 @@ struct rpmh_request { >>> * @cache: the list of cached requests >>> * @lock: synchronize access to the controller data >>> * @dirty: was the cache updated since flush >>> + * @batch_cache: Cache sleep a

Re: [PATCH v8 09/10] drivers: qcom: rpmh: add support for batch RPMH request

2018-05-14 Thread Lina Iyer
Hi Doug, Will explain only the key points now. On Fri, May 11 2018 at 14:19 -0600, Doug Anderson wrote: Hi, On Wed, May 9, 2018 at 10:01 AM, Lina Iyer wrote: /** @@ -77,12 +82,14 @@ struct rpmh_request { * @cache: the list of cached requests * @lock: synchronize access to the controlle

Re: [PATCH v8 09/10] drivers: qcom: rpmh: add support for batch RPMH request

2018-05-11 Thread Doug Anderson
Hi, On Wed, May 9, 2018 at 10:01 AM, Lina Iyer wrote: > /** > @@ -77,12 +82,14 @@ struct rpmh_request { > * @cache: the list of cached requests > * @lock: synchronize access to the controller data > * @dirty: was the cache updated since flush > + * @batch_cache: Cache sleep and wake reques

Re: [PATCH v8 09/10] drivers: qcom: rpmh: add support for batch RPMH request

2018-05-10 Thread Lina Iyer
On Wed, May 09 2018 at 16:03 -0600, Matthias Kaehlcke wrote: On Wed, May 09, 2018 at 11:01:58AM -0600, Lina Iyer wrote: Platform drivers need make a lot of resource state requests at the same time, say, at the start or end of an usecase. It can be quite inefficient to send each request separatel

Re: [PATCH v8 09/10] drivers: qcom: rpmh: add support for batch RPMH request

2018-05-09 Thread Matthias Kaehlcke
On Wed, May 09, 2018 at 11:01:58AM -0600, Lina Iyer wrote: > Platform drivers need make a lot of resource state requests at the same > time, say, at the start or end of an usecase. It can be quite > inefficient to send each request separately. Instead they can give the > RPMH library a batch of req