Re: [PATCH v8 09/16] clockevents/drivers: Add STM32 Timer driver

2015-05-19 Thread Maxime Coquelin
2015-05-19 16:50 GMT+02:00 Russell King - ARM Linux : > > config CLKSRC_STM32 > bool "Clocksource for STM32 SoCs" if COMPILE_TEST > depends on OF > select CLKSRC_MMIO > > This permits CLKSRC_STM32 to be selected by STM32 (provided OF is enabled, > it's always going to be for

Re: [PATCH v8 09/16] clockevents/drivers: Add STM32 Timer driver

2015-05-19 Thread Daniel Lezcano
On 05/19/2015 04:41 PM, Maxime Coquelin wrote: 2015-05-19 15:49 GMT+02:00 Daniel Lezcano : It is not exactly as the initial patch. I think Arnd is proposing: config CLKSRC_STM32 bool "Clocksource for STM32 SoCs" if COMPILE_TEST select CLKSRC_MMIO Isn't "depends on OF" mi

Re: [PATCH v8 09/16] clockevents/drivers: Add STM32 Timer driver

2015-05-19 Thread Russell King - ARM Linux
On Tue, May 19, 2015 at 04:41:58PM +0200, Maxime Coquelin wrote: > 2015-05-19 15:49 GMT+02:00 Daniel Lezcano : > > > > > > It is not exactly as the initial patch. > > > > I think Arnd is proposing: > > > > config CLKSRC_STM32 > > bool "Clocksource for STM32 SoCs" if COMPILE_TEST > >

Re: [PATCH v8 09/16] clockevents/drivers: Add STM32 Timer driver

2015-05-19 Thread Arnd Bergmann
On Tuesday 19 May 2015 15:49:52 Daniel Lezcano wrote: > On 05/19/2015 03:42 PM, Maxime Coquelin wrote: > > 2015-05-19 12:55 GMT+02:00 Arnd Bergmann : > >> Please also make it possible to select this driver on other architectures > >> with COMPILE_TEST, so we get coverage from all the x86 test infra

Re: [PATCH v8 09/16] clockevents/drivers: Add STM32 Timer driver

2015-05-19 Thread Maxime Coquelin
2015-05-19 15:49 GMT+02:00 Daniel Lezcano : > > > It is not exactly as the initial patch. > > I think Arnd is proposing: > > config CLKSRC_STM32 > bool "Clocksource for STM32 SoCs" if COMPILE_TEST > select CLKSRC_MMIO > Isn't "depends on OF" missing for COMPILE_TEST case? Other th

Re: [PATCH v8 09/16] clockevents/drivers: Add STM32 Timer driver

2015-05-19 Thread Daniel Lezcano
On 05/19/2015 03:42 PM, Maxime Coquelin wrote: 2015-05-19 12:55 GMT+02:00 Arnd Bergmann : Please also make it possible to select this driver on other architectures with COMPILE_TEST, so we get coverage from all the x86 test infrastructure. You proposal is to revert back to the original patch,

Re: [PATCH v8 09/16] clockevents/drivers: Add STM32 Timer driver

2015-05-19 Thread Maxime Coquelin
2015-05-19 12:55 GMT+02:00 Arnd Bergmann : > Please also make it possible to select this driver on other architectures > with COMPILE_TEST, so we get coverage from all the x86 test infrastructure. You proposal is to revert back to the original patch, except that ARCH_STM32 should select CLKSRC_STM

Re: [PATCH v8 09/16] clockevents/drivers: Add STM32 Timer driver

2015-05-19 Thread Maxime Coquelin
2015-05-19 15:00 GMT+02:00 Russell King - ARM Linux : > On Tue, May 19, 2015 at 02:56:43PM +0200, Thomas Gleixner wrote: >> Folks, can you please trim your replies. It's a PITA to scroll down >> through several pages to find a single line of content. > > Absolutely right. Too many people do not do

Re: [PATCH v8 09/16] clockevents/drivers: Add STM32 Timer driver

2015-05-19 Thread Russell King - ARM Linux
On Tue, May 19, 2015 at 02:56:43PM +0200, Thomas Gleixner wrote: > On Tue, 19 May 2015, Maxime Coquelin wrote: > > 2015-05-19 11:59 GMT+02:00 Daniel Lezcano : > > >> Is the below Kconfig entry fine for you? > > >> > > >> config CLKSRC_STM32 > > >> def_bool y if ARCH_STM32 > > >> select CL

Re: [PATCH v8 09/16] clockevents/drivers: Add STM32 Timer driver

2015-05-19 Thread Thomas Gleixner
On Tue, 19 May 2015, Maxime Coquelin wrote: > 2015-05-19 11:59 GMT+02:00 Daniel Lezcano : > >> Is the below Kconfig entry fine for you? > >> > >> config CLKSRC_STM32 > >> def_bool y if ARCH_STM32 > >> select CLKSRC_MMIO > > > > > > config CLKSRC_STM32 > > bool > > select C

Re: [PATCH v8 09/16] clockevents/drivers: Add STM32 Timer driver

2015-05-19 Thread Arnd Bergmann
On Tuesday 19 May 2015 12:02:59 Maxime Coquelin wrote: > > > > config CLKSRC_STM32 > > bool > > select CLKSRC_MMIO > > > > and in the arch/arm/mach-stm32/Kconfig add select CLKSRC_STM32 > > Ok, I will send a patch for arch/arm/Kconfig, as Arnd already applied > the one intruducing

Re: [PATCH v8 09/16] clockevents/drivers: Add STM32 Timer driver

2015-05-19 Thread Maxime Coquelin
2015-05-19 11:59 GMT+02:00 Daniel Lezcano : > On 05/19/2015 11:44 AM, Maxime Coquelin wrote: >> >> 2015-05-19 11:06 GMT+02:00 Daniel Lezcano : >>> >>> On 05/19/2015 10:55 AM, Maxime Coquelin wrote: 2015-05-19 10:16 GMT+02:00 Daniel Lezcano : > > > On 05/18/2015 04:03 PM,

Re: [PATCH v8 09/16] clockevents/drivers: Add STM32 Timer driver

2015-05-19 Thread Daniel Lezcano
On 05/19/2015 11:44 AM, Maxime Coquelin wrote: 2015-05-19 11:06 GMT+02:00 Daniel Lezcano : On 05/19/2015 10:55 AM, Maxime Coquelin wrote: 2015-05-19 10:16 GMT+02:00 Daniel Lezcano : On 05/18/2015 04:03 PM, Maxime Coquelin wrote: 2015-05-18 15:10 GMT+02:00 Daniel Lezcano : On 05/09/2015

Re: [PATCH v8 09/16] clockevents/drivers: Add STM32 Timer driver

2015-05-19 Thread Maxime Coquelin
2015-05-19 11:06 GMT+02:00 Daniel Lezcano : > On 05/19/2015 10:55 AM, Maxime Coquelin wrote: >> >> 2015-05-19 10:16 GMT+02:00 Daniel Lezcano : >>> >>> On 05/18/2015 04:03 PM, Maxime Coquelin wrote: 2015-05-18 15:10 GMT+02:00 Daniel Lezcano : > > > On 05/09/2015 09:53 AM,

Re: [PATCH v8 09/16] clockevents/drivers: Add STM32 Timer driver

2015-05-19 Thread Daniel Lezcano
On 05/19/2015 10:55 AM, Maxime Coquelin wrote: 2015-05-19 10:16 GMT+02:00 Daniel Lezcano : On 05/18/2015 04:03 PM, Maxime Coquelin wrote: 2015-05-18 15:10 GMT+02:00 Daniel Lezcano : On 05/09/2015 09:53 AM, Maxime Coquelin wrote: STM32 MCUs feature 16 and 32 bits general purpose timers wit

Re: [PATCH v8 09/16] clockevents/drivers: Add STM32 Timer driver

2015-05-19 Thread Maxime Coquelin
2015-05-19 10:16 GMT+02:00 Daniel Lezcano : > On 05/18/2015 04:03 PM, Maxime Coquelin wrote: >> >> 2015-05-18 15:10 GMT+02:00 Daniel Lezcano : >>> >>> On 05/09/2015 09:53 AM, Maxime Coquelin wrote: STM32 MCUs feature 16 and 32 bits general purpose timers with prescalers. Th

Re: [PATCH v8 09/16] clockevents/drivers: Add STM32 Timer driver

2015-05-19 Thread Daniel Lezcano
On 05/18/2015 04:03 PM, Maxime Coquelin wrote: 2015-05-18 15:10 GMT+02:00 Daniel Lezcano : On 05/09/2015 09:53 AM, Maxime Coquelin wrote: STM32 MCUs feature 16 and 32 bits general purpose timers with prescalers. The drivers detects whether the time is 16 or 32 bits, and applies a 1024 prescale

Re: [PATCH v8 09/16] clockevents/drivers: Add STM32 Timer driver

2015-05-18 Thread Maxime Coquelin
2015-05-18 15:10 GMT+02:00 Daniel Lezcano : > On 05/09/2015 09:53 AM, Maxime Coquelin wrote: >> >> STM32 MCUs feature 16 and 32 bits general purpose timers with prescalers. >> The drivers detects whether the time is 16 or 32 bits, and applies a >> 1024 prescaler value if it is 16 bits. >> >> Review

Re: [PATCH v8 09/16] clockevents/drivers: Add STM32 Timer driver

2015-05-18 Thread Daniel Lezcano
On 05/09/2015 09:53 AM, Maxime Coquelin wrote: STM32 MCUs feature 16 and 32 bits general purpose timers with prescalers. The drivers detects whether the time is 16 or 32 bits, and applies a 1024 prescaler value if it is 16 bits. Reviewed-by: Linus Walleij Tested-by: Chanwoo Choi Signed-off-by: