Re: [PATCH v8 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-03-11 Thread Yash Shah
On Mon, Mar 11, 2019 at 6:59 PM Uwe Kleine-König wrote: > > Hello, > > On Mon, Mar 11, 2019 at 05:10:17PM +0530, Yash Shah wrote: > > On Fri, Mar 8, 2019 at 5:27 PM Uwe Kleine-König > > wrote: > > > On Fri, Mar 08, 2019 at 04:59:36PM +0530, Yash Shah wrote: > > > > On Thu, Mar 7, 2019 at 8:57 PM

Re: [PATCH v8 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-03-11 Thread Uwe Kleine-König
Hello, On Mon, Mar 11, 2019 at 05:10:17PM +0530, Yash Shah wrote: > On Fri, Mar 8, 2019 at 5:27 PM Uwe Kleine-König > wrote: > > On Fri, Mar 08, 2019 at 04:59:36PM +0530, Yash Shah wrote: > > > On Thu, Mar 7, 2019 at 8:57 PM Uwe Kleine-König > > > wrote: > > > > > + if (state->period != cur_

Re: [PATCH v8 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-03-11 Thread Yash Shah
On Fri, Mar 8, 2019 at 5:27 PM Uwe Kleine-König wrote: > > Hello, > > On Fri, Mar 08, 2019 at 04:59:36PM +0530, Yash Shah wrote: > > On Thu, Mar 7, 2019 at 8:57 PM Uwe Kleine-König > > wrote: > > > > +static int pwm_sifive_apply(struct pwm_chip *chip, struct pwm_device > > > > *dev, > > > > +

Re: [PATCH v8 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-03-08 Thread Uwe Kleine-König
Hello, On Fri, Mar 08, 2019 at 04:59:36PM +0530, Yash Shah wrote: > On Thu, Mar 7, 2019 at 8:57 PM Uwe Kleine-König > wrote: > > > +static int pwm_sifive_apply(struct pwm_chip *chip, struct pwm_device > > > *dev, > > > + struct pwm_state *state) > > > +{ > > > + struc

Re: [PATCH v8 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-03-08 Thread Yash Shah
On Thu, Mar 7, 2019 at 8:57 PM Uwe Kleine-König wrote: > > Hello, > > On Fri, Mar 01, 2019 at 04:23:19PM +0530, Yash Shah wrote: > > Adds a PWM driver for PWM chip present in SiFive's HiFive Unleashed SoC. > > > > Signed-off-by: Wesley W. Terpstra > > [Atish: Various fixes and code cleanup] > > S

Re: [PATCH v8 2/2] pwm: sifive: Add a driver for SiFive SoC PWM

2019-03-07 Thread Uwe Kleine-König
Hello, On Fri, Mar 01, 2019 at 04:23:19PM +0530, Yash Shah wrote: > Adds a PWM driver for PWM chip present in SiFive's HiFive Unleashed SoC. > > Signed-off-by: Wesley W. Terpstra > [Atish: Various fixes and code cleanup] > Signed-off-by: Atish Patra > Signed-off-by: Yash Shah > --- > drivers/