Re: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-21 Thread Eddie Huang
Hi, Please see my reply below (I skip comments that already reply in another mail). On Wed, 2015-05-20 at 10:57 +0200, Uwe Kleine-König wrote: > Hello, > > now that I understood the formula some more comments to the calculation. > > On Tue, May 19, 2015 at 12:40:08AM +0800, Eddie Huang wrote: >

Re: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-20 Thread Uwe Kleine-König
Hello, On Wed, May 20, 2015 at 09:03:40PM +0800, Yingjoe Chen wrote: > On Wed, 2015-05-20 at 10:57 +0200, Uwe Kleine-König wrote: > > On Tue, May 19, 2015 at 12:40:08AM +0800, Eddie Huang wrote: > > > + if (i2c->speed_hz > MAX_HS_MODE_SPEED) > > > + return -EINVAL; > > According to the pla

Re: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-20 Thread Yingjoe Chen
Hi Uwe, On Wed, 2015-05-20 at 10:57 +0200, Uwe Kleine-König wrote: > Hello, > > now that I understood the formula some more comments to the calculation. > > On Tue, May 19, 2015 at 12:40:08AM +0800, Eddie Huang wrote: > > +#define I2C_DEFAUT_SPEED 10 /* hz */ > DEFAULT? > > > +#

Re: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-20 Thread Uwe Kleine-König
Hello, now that I understood the formula some more comments to the calculation. On Tue, May 19, 2015 at 12:40:08AM +0800, Eddie Huang wrote: > +#define I2C_DEFAUT_SPEED 10 /* hz */ DEFAULT? > +#define MAX_FS_MODE_SPEED40 > +#define MAX_HS_MODE_SPEED34

Re: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-20 Thread Uwe Kleine-König
Hello Eddie, On Wed, May 20, 2015 at 03:59:35PM +0800, Eddie Huang wrote: > On Wed, 2015-05-20 at 09:11 +0200, Uwe Kleine-König wrote: > > On Wed, May 20, 2015 at 10:40:11AM +0800, Eddie Huang wrote: > > > On Mon, 2015-05-18 at 20:43 +0200, Uwe Kleine-König wrote: > > > > On Tue, May 19, 2015 at 1

Re: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-20 Thread Eddie Huang
Hi Uwe, On Wed, 2015-05-20 at 09:11 +0200, Uwe Kleine-König wrote: > Hello Eddie, > > On Wed, May 20, 2015 at 10:40:11AM +0800, Eddie Huang wrote: > > On Mon, 2015-05-18 at 20:43 +0200, Uwe Kleine-König wrote: > > > On Tue, May 19, 2015 at 12:40:08AM +0800, Eddie Huang wrote: > > > > +/* calculat

Re: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-20 Thread Uwe Kleine-König
Hello Eddie, On Wed, May 20, 2015 at 10:40:11AM +0800, Eddie Huang wrote: > On Mon, 2015-05-18 at 20:43 +0200, Uwe Kleine-König wrote: > > On Tue, May 19, 2015 at 12:40:08AM +0800, Eddie Huang wrote: > > > +/* calculate i2c port speed */ > > It would be nice to summarize the clock frequency settin

Re: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-19 Thread Eddie Huang
Hi Uwe, On Tue, 2015-05-19 at 21:49 +0200, Uwe Kleine-König wrote: > Hello Matthias, > > On Tue, May 19, 2015 at 04:48:23PM +0200, Matthias Brugger wrote: > > 2015-05-18 20:43 GMT+02:00 Uwe Kleine-König > > : > > > On Tue, May 19, 2015 at 12:40:08AM +0800, Eddie Huang wrote: > > >> [...] > > >>

Re: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-19 Thread Yingjoe Chen
On Tue, 2015-05-19 at 16:48 +0200, Matthias Brugger wrote: > 2015-05-18 20:43 GMT+02:00 Uwe Kleine-König : <...> > >> --- /dev/null > >> +++ b/drivers/i2c/busses/i2c-mt65xx.c > >> @@ -0,0 +1,675 @@ > >> +/* > >> + * Copyright (c) 2014 MediaTek Inc. > >> + * Author: Xudong.chen > > s/Xudong.chen/Xu

Re: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-19 Thread Eddie Huang
Hi Uwe, On Mon, 2015-05-18 at 20:43 +0200, Uwe Kleine-König wrote: > Hello, > > On Tue, May 19, 2015 at 12:40:08AM +0800, Eddie Huang wrote: > > From: Xudong Chen > > > > The mediatek SoCs have I2C controller that handle I2C transfer. > > This patch include common I2C bus driver. > > This drive

Re: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-19 Thread Uwe Kleine-König
Hello Matthias, On Tue, May 19, 2015 at 04:48:23PM +0200, Matthias Brugger wrote: > 2015-05-18 20:43 GMT+02:00 Uwe Kleine-König : > > On Tue, May 19, 2015 at 12:40:08AM +0800, Eddie Huang wrote: > >> [...] > >> drivers/i2c/busses/i2c-mt65xx.c | 675 > >> >

Re: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-19 Thread Matthias Brugger
2015-05-18 20:43 GMT+02:00 Uwe Kleine-König : > Hello, > > On Tue, May 19, 2015 at 12:40:08AM +0800, Eddie Huang wrote: >> From: Xudong Chen >> >> The mediatek SoCs have I2C controller that handle I2C transfer. >> This patch include common I2C bus driver. >> This driver is compatible with I2C cont

Re: [PATCH v8 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-18 Thread Uwe Kleine-König
Hello, On Tue, May 19, 2015 at 12:40:08AM +0800, Eddie Huang wrote: > From: Xudong Chen > > The mediatek SoCs have I2C controller that handle I2C transfer. > This patch include common I2C bus driver. > This driver is compatible with I2C controller on mt65xx/mt81xx. > > Signed-off-by: Xudong Che