Re: [PATCH v8 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-08-26 Thread Tomi Valkeinen
Hi, On 11/08/2020 05:36, Laurent Pinchart wrote: >> +{ >> +u32 max_bw, req_bw, bpp; >> + >> +bpp = cdns_mhdp_get_bpp(&mhdp->display_fmt); >> +req_bw = mode->clock * bpp / 8; >> +max_bw = lanes * rate; > mode->clock is in kHz, while rate is expressed in 10kHz unit if I'm not > mista

Re: [PATCH v8 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-08-23 Thread Laurent Pinchart
Hi Tomi, On Fri, Aug 14, 2020 at 12:29:35PM +0300, Tomi Valkeinen wrote: > On 11/08/2020 05:36, Laurent Pinchart wrote: > > >> +static int cdns_mhdp_mailbox_write(struct cdns_mhdp_device *mhdp, u8 val) > >> +{ > >> + int ret, full; > >> + > >> + WARN_ON(!mutex_is_locked(&mhdp->mbox_mutex)); > >

Re: [PATCH v8 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-08-23 Thread Laurent Pinchart
Hi Tomi, On Fri, Aug 14, 2020 at 11:22:09AM +0300, Tomi Valkeinen wrote: > On 11/08/2020 05:36, Laurent Pinchart wrote: > > >> +static int cdns_mhdp_connector_init(struct cdns_mhdp_device *mhdp) > >> +{ > >> + u32 bus_format = MEDIA_BUS_FMT_RGB121212_1X36; > >> + struct drm_connector *conn = &m

Re: [PATCH v8 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-08-14 Thread Tomi Valkeinen
On 11/08/2020 05:36, Laurent Pinchart wrote: >> +static int cdns_mhdp_mailbox_write(struct cdns_mhdp_device *mhdp, u8 val) >> +{ >> +int ret, full; >> + >> +WARN_ON(!mutex_is_locked(&mhdp->mbox_mutex)); >> + >> +ret = readx_poll_timeout(readl, mhdp->regs + CDNS_MAILBOX_FULL, >> +

Re: [PATCH v8 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-08-14 Thread Tomi Valkeinen
On 11/08/2020 05:36, Laurent Pinchart wrote: >> +static int cdns_mhdp_connector_init(struct cdns_mhdp_device *mhdp) >> +{ >> +u32 bus_format = MEDIA_BUS_FMT_RGB121212_1X36; >> +struct drm_connector *conn = &mhdp->connector; >> +struct drm_bridge *bridge = &mhdp->bridge; >> +int ret

Re: [PATCH v8 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-08-10 Thread Laurent Pinchart
Hi Swapnil, Thank you for the patch. On Thu, Aug 06, 2020 at 01:34:31PM +0200, Swapnil Jakhade wrote: > Add a new DRM bridge driver for Cadence MHDP DPTX IP used in TI J721e SoC. > MHDP DPTX IP is the component that complies with VESA DisplayPort (DP) and > embedded Display Port (eDP) standards.

Re: [PATCH v8 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-08-07 Thread Tomi Valkeinen
Hi Swapnil, On 06/08/2020 14:34, Swapnil Jakhade wrote: > Add a new DRM bridge driver for Cadence MHDP DPTX IP used in TI J721e SoC. > MHDP DPTX IP is the component that complies with VESA DisplayPort (DP) and > embedded Display Port (eDP) standards. It integrates uCPU running the > embedded Firmw