Re: [PATCH v8 6/6] x86/tsc: use tsc early

2017-11-15 Thread Pavel Tatashin
> s/sched clock early/early sched clock/ Ok, changed > > Yes, the function names confused me, the actually purpose of > tsc_early_fini() is switching schedule clock to the final one. right? > > How about replacing *return;* with *goto final_sched_clock;* Done I will send new patchset soon, with

Re: [PATCH v8 6/6] x86/tsc: use tsc early

2017-11-14 Thread Dou Liyang
Hi Pavel, At 11/15/2017 05:46 AM, Pavel Tatashin wrote: Hi Dou, Great comments, my replies below: static inline unsigned long long paravirt_sched_clock(void) { - return PVOP_CALL0(unsigned long long, pv_time_ops.sched_clock); + return PVOP_CALL0(unsigned long long, pv_time_ops.a

Re: [PATCH v8 6/6] x86/tsc: use tsc early

2017-11-14 Thread Pavel Tatashin
Hi Dou, Great comments, my replies below: >> static inline unsigned long long paravirt_sched_clock(void) >> { >> - return PVOP_CALL0(unsigned long long, pv_time_ops.sched_clock); >> + return PVOP_CALL0(unsigned long long, >> pv_time_ops.active_sched_clock); >> } >> > > Should in th

Re: [PATCH v8 6/6] x86/tsc: use tsc early

2017-11-12 Thread Dou Liyang
Hi Pavel, At 11/09/2017 11:02 AM, Pavel Tatashin wrote: This patch adds early clock feature to x86 platforms. tsc_early_init(): Determines offset, shift and multiplier for the early clock based on the TSC frequency. tsc_early_fini() Implement the finish part of early tsc feature, prints messag