Re: [PATCH v9 7/7] intel_sgx: in-kernel launch enclave

2017-12-19 Thread Jarkko Sakkinen
On Tue, 2017-12-19 at 17:36 +0200, Andy Shevchenko wrote: > On Tue, Dec 19, 2017 at 3:59 PM, Jarkko Sakkinen > wrote: > > > I streamlined the IPC quite a bit. See the attached patch. Can be > > applied on top of this patch. > > Sorry, I didn't look into actual code, but WRT the attached patch, >

Re: [PATCH v9 7/7] intel_sgx: in-kernel launch enclave

2017-12-19 Thread Andy Shevchenko
On Tue, Dec 19, 2017 at 3:59 PM, Jarkko Sakkinen wrote: > I streamlined the IPC quite a bit. See the attached patch. Can be > applied on top of this patch. Sorry, I didn't look into actual code, but WRT the attached patch, wouldn't be better / possible to use pr_fmt() to print "intel_sgx:" prefi

Re: [PATCH v9 7/7] intel_sgx: in-kernel launch enclave

2017-12-19 Thread Jarkko Sakkinen
On Sat, Dec 16, 2017 at 06:19:54PM +0200, Jarkko Sakkinen wrote: > The Launch Enclave (LE) generates cryptographic launch tokens for user > enclaves. A launch token is used by EINIT to check whether the enclave > is authorized to launch or not. By having its own launch enclave, Linux > has full con