Re: [PATCH v9 net-next 5/7] net: simple poll/select low latency socket poll

2013-06-05 Thread Eliezer Tamir
On 05/06/2013 18:20, Eric Dumazet wrote: On Wed, 2013-06-05 at 16:41 +0300, Eliezer Tamir wrote: On 05/06/2013 16:30, Eric Dumazet wrote: I am a bit uneasy with this one, because an applicatio polling() on one thousand file descriptors using select()/poll(), will call sk_poll_ll() one thousan

Re: [PATCH v9 net-next 5/7] net: simple poll/select low latency socket poll

2013-06-05 Thread Eric Dumazet
On Wed, 2013-06-05 at 16:41 +0300, Eliezer Tamir wrote: > On 05/06/2013 16:30, Eric Dumazet wrote: > > I am a bit uneasy with this one, because an applicatio polling() on one > > thousand file descriptors using select()/poll(), will call sk_poll_ll() > > one thousand times. > > But we call sk_pol

Re: [PATCH v9 net-next 5/7] net: simple poll/select low latency socket poll

2013-06-05 Thread Eliezer Tamir
On 05/06/2013 17:17, Eric Dumazet wrote: On Wed, 2013-06-05 at 06:56 -0700, Eric Dumazet wrote: This looks quite easy, by adding in include/uapi/asm-generic/poll.h #define POLL_LL 0x8000 And do the sk_poll_ll() call only if flag is set. I do not think we have to support select(), as its lega

Re: [PATCH v9 net-next 5/7] net: simple poll/select low latency socket poll

2013-06-05 Thread Eric Dumazet
On Wed, 2013-06-05 at 06:56 -0700, Eric Dumazet wrote: > This looks quite easy, by adding in include/uapi/asm-generic/poll.h > > #define POLL_LL 0x8000 > > And do the sk_poll_ll() call only if flag is set. > > I do not think we have to support select(), as its legacy interface, and > people wan

RE: [PATCH v9 net-next 5/7] net: simple poll/select low latency socket poll

2013-06-05 Thread Eric Dumazet
On Wed, 2013-06-05 at 14:49 +0100, David Laight wrote: > > I am a bit uneasy with this one, because an applicatio polling() on one > > thousand file descriptors using select()/poll(), will call sk_poll_ll() > > one thousand times. > > Anything calling poll() on 1000 fds probably has performance >

Re: [PATCH v9 net-next 5/7] net: simple poll/select low latency socket poll

2013-06-05 Thread Eric Dumazet
On Wed, 2013-06-05 at 16:41 +0300, Eliezer Tamir wrote: > On 05/06/2013 16:30, Eric Dumazet wrote: > > On Wed, 2013-06-05 at 13:34 +0300, Eliezer Tamir wrote: > >> A very naive select/poll busy-poll support. > >> Add busy-polling to sock_poll(). > >> When poll/select have nothing to report, call th

RE: [PATCH v9 net-next 5/7] net: simple poll/select low latency socket poll

2013-06-05 Thread David Laight
> I am a bit uneasy with this one, because an applicatio polling() on one > thousand file descriptors using select()/poll(), will call sk_poll_ll() > one thousand times. Anything calling poll() on 1000 fds probably has performance issues already! Which is why kevent schemes have been added. At le

Re: [PATCH v9 net-next 5/7] net: simple poll/select low latency socket poll

2013-06-05 Thread Eliezer Tamir
On 05/06/2013 16:30, Eric Dumazet wrote: On Wed, 2013-06-05 at 13:34 +0300, Eliezer Tamir wrote: A very naive select/poll busy-poll support. Add busy-polling to sock_poll(). When poll/select have nothing to report, call the low-level sock_poll() again until we are out of time or we find somethin

Re: [PATCH v9 net-next 5/7] net: simple poll/select low latency socket poll

2013-06-05 Thread Eric Dumazet
On Wed, 2013-06-05 at 13:34 +0300, Eliezer Tamir wrote: > A very naive select/poll busy-poll support. > Add busy-polling to sock_poll(). > When poll/select have nothing to report, call the low-level > sock_poll() again until we are out of time or we find something. > Right now we poll every socket