Re: [PATCHv2 02/12] acpi/hmat: Parse and report heterogeneous memory

2018-12-11 Thread Dan Williams
On Tue, Dec 11, 2018 at 12:47 PM Keith Busch wrote: > > On Tue, Dec 11, 2018 at 12:29:45PM -0800, Dan Williams wrote: > > On Tue, Dec 11, 2018 at 8:58 AM Keith Busch wrote: > > > +static int __init > > > +acpi_parse_cache(union acpi_subtable_headers *header, const unsigned > > > long end) > > >

Re: [PATCHv2 02/12] acpi/hmat: Parse and report heterogeneous memory

2018-12-11 Thread Keith Busch
On Tue, Dec 11, 2018 at 12:29:45PM -0800, Dan Williams wrote: > On Tue, Dec 11, 2018 at 8:58 AM Keith Busch wrote: > > +static int __init > > +acpi_parse_cache(union acpi_subtable_headers *header, const unsigned long > > end) > > +{ > > + struct acpi_hmat_cache *cache = (void *)header; > >

Re: [PATCHv2 02/12] acpi/hmat: Parse and report heterogeneous memory

2018-12-11 Thread Dan Williams
On Tue, Dec 11, 2018 at 8:58 AM Keith Busch wrote: > > On Mon, Dec 10, 2018 at 10:03:40PM -0800, Dan Williams wrote: > > I have a use case to detect the presence of a memory-side-cache early > > at init time [1]. To me this means that hmat_init() needs to happen as > > a part of acpi_numa_init().

Re: [PATCHv2 02/12] acpi/hmat: Parse and report heterogeneous memory

2018-12-11 Thread Keith Busch
On Mon, Dec 10, 2018 at 10:03:40PM -0800, Dan Williams wrote: > I have a use case to detect the presence of a memory-side-cache early > at init time [1]. To me this means that hmat_init() needs to happen as > a part of acpi_numa_init(). Subsequently I think that also means that > the sysfs portion

Re: [PATCHv2 02/12] acpi/hmat: Parse and report heterogeneous memory

2018-12-10 Thread Dan Williams
On Mon, Dec 10, 2018 at 5:05 PM Keith Busch wrote: > > Systems may provide different memory types and export this information > in the ACPI Heterogeneous Memory Attribute Table (HMAT). Parse these > tables provided by the platform and report the memory access and caching > attributes. > > Signed-o