Re: [PATCHv2 1/2] x86/mm: Move LDT remap out of KASLR region on 5-level paging

2018-10-25 Thread Baoquan He
On 10/25/18 at 10:24am, Kirill A. Shutemov wrote: > On Thu, Oct 25, 2018 at 10:18:09AM +0800, Baoquan He wrote: > > > We don't touch 4 pgd slot gap just before the direct mapping reserved > > > for a hypervisor, but move direct mapping by one slot instead. > > > > > > The LDT mapping is per-mm, so

Re: [PATCHv2 1/2] x86/mm: Move LDT remap out of KASLR region on 5-level paging

2018-10-25 Thread Kirill A. Shutemov
On Thu, Oct 25, 2018 at 10:18:09AM +0800, Baoquan He wrote: > > We don't touch 4 pgd slot gap just before the direct mapping reserved > > for a hypervisor, but move direct mapping by one slot instead. > > > > The LDT mapping is per-mm, so we cannot move it into P4D page table next > > to CPU_ENTRY

Re: [PATCHv2 1/2] x86/mm: Move LDT remap out of KASLR region on 5-level paging

2018-10-24 Thread Baoquan He
Hi Kirill, Thanks for making this patchset. I have small concerns, please see the inline comments. On 10/24/18 at 03:51pm, Kirill A. Shutemov wrote: > On 5-level paging LDT remap area is placed in the middle of > KASLR randomization region and it can overlap with direct mapping, > vmalloc or vmap

Re: [PATCHv2 1/2] x86/mm: Move LDT remap out of KASLR region on 5-level paging

2018-10-24 Thread Matthew Wilcox
On Wed, Oct 24, 2018 at 03:51:11PM +0300, Kirill A. Shutemov wrote: > +++ b/Documentation/x86/x86_64/mm.txt > @@ -34,23 +34,24 @@ > __||__|_|___ > > |__