Re: [PATCHv2 1/5] rtc: s3c: Define s3c_rtc structure to remove global variables.

2014-08-27 Thread Chanwoo Choi
Dear Andrew, On 08/27/2014 06:31 AM, Andrew Morton wrote: > On Mon, 25 Aug 2014 09:57:33 +0900 Chanwoo Choi wrote: > >> Dear Andrew, >> >> On 08/23/2014 05:42 AM, Andrew Morton wrote: >>> On Tue, 12 Aug 2014 11:01:07 +0900 y...@samsung.com wrote: >>> This patch define s3c_rtc structure inc

Re: [PATCHv2 1/5] rtc: s3c: Define s3c_rtc structure to remove global variables.

2014-08-26 Thread Andrew Morton
On Mon, 25 Aug 2014 09:57:33 +0900 Chanwoo Choi wrote: > Dear Andrew, > > On 08/23/2014 05:42 AM, Andrew Morton wrote: > > On Tue, 12 Aug 2014 11:01:07 +0900 y...@samsung.com wrote: > > > >> This patch define s3c_rtc structure including necessary variables for S3C > >> RTC > >> device instead

Re: [PATCHv2 1/5] rtc: s3c: Define s3c_rtc structure to remove global variables.

2014-08-24 Thread Chanwoo Choi
Dear Andrew, On 08/23/2014 05:42 AM, Andrew Morton wrote: > On Tue, 12 Aug 2014 11:01:07 +0900 y...@samsung.com wrote: > >> This patch define s3c_rtc structure including necessary variables for S3C RTC >> device instead of global variables. This patch improves the readability by >> removing glob

Re: [PATCHv2 1/5] rtc: s3c: Define s3c_rtc structure to remove global variables.

2014-08-22 Thread Andrew Morton
On Tue, 12 Aug 2014 11:01:07 +0900 y...@samsung.com wrote: > This patch define s3c_rtc structure including necessary variables for S3C RTC > device instead of global variables. This patch improves the readability by > removing global variables. Below is the v1->v2 delta. Why were all those tests