Re: [PATCHv2 2/5] mmc: sdhci-bcm2835: make shift calculations consistent

2014-11-04 Thread Scott Branden
On 14-11-04 08:48 PM, Stephen Warren wrote: On 10/30/2014 12:36 AM, Scott Branden wrote: Make the shift calculations consistent rather than having different implementations to calculate the same thing. diff --git a/drivers/mmc/host/sdhci-bcm2835.c b/drivers/mmc/host/sdhci-bcm2835.c +#defin

Re: [PATCHv2 2/5] mmc: sdhci-bcm2835: make shift calculations consistent

2014-11-04 Thread Stephen Warren
On 10/30/2014 12:36 AM, Scott Branden wrote: > Make the shift calculations consistent rather than having different > implementations to calculate the same thing. > diff --git a/drivers/mmc/host/sdhci-bcm2835.c > b/drivers/mmc/host/sdhci-bcm2835.c > +#define REG_OFFSET_IN_BITS(reg) ((reg) << 3 &