Re: [PATCHv2 25/59] keys/mktme: Preparse the MKTME key payload

2019-08-13 Thread Ben Boeckel
On Mon, Aug 05, 2019 at 13:31:02 -0700, Alison Schofield wrote: > It's not currently checked, but should be. > I'll add it as shown above. > Thanks for the review, Thanks. Seeing how this works elsewhere now, feel free to add my review with the proposed check to the new patch. Reviewed-by: Ben B

Re: [PATCHv2 25/59] keys/mktme: Preparse the MKTME key payload

2019-08-05 Thread Alison Schofield
On Mon, Aug 05, 2019 at 07:58:19AM -0400, Ben Boeckel wrote: > On Wed, Jul 31, 2019 at 18:07:39 +0300, Kirill A. Shutemov wrote: > > From: Alison Schofield > > +/* Make sure arguments are correct for the TYPE of key requested */ > > +static int mktme_check_options(u32 *payload, unsigned long token

Re: [PATCHv2 25/59] keys/mktme: Preparse the MKTME key payload

2019-08-05 Thread Ben Boeckel
On Wed, Jul 31, 2019 at 18:07:39 +0300, Kirill A. Shutemov wrote: > From: Alison Schofield > +/* Make sure arguments are correct for the TYPE of key requested */ > +static int mktme_check_options(u32 *payload, unsigned long token_mask, > +enum mktme_type type, enum mktm