Re: [PATCHv2 net-next 5/9] openvswitch: Add conntrack action

2015-08-10 Thread Joe Stringer
On 6 August 2015 at 14:36, Pravin Shelar wrote: +static void ovs_fragment(struct vport *vport, struct sk_buff *skb, +unsigned int mru, __be16 ethertype) +{ + if (skb_network_offset(skb) > MAX_L2_LEN) { + OVS_NLERR(1, "L2 header t

Re: [PATCHv2 net-next 5/9] openvswitch: Add conntrack action

2015-08-06 Thread Pravin Shelar
On Thu, Aug 6, 2015 at 11:07 AM, Joe Stringer wrote: > On 5 August 2015 at 15:31, Pravin Shelar wrote: >> On Tue, Aug 4, 2015 at 9:49 PM, Joe Stringer wrote: >> I got sparse warning: >> >> net/openvswitch/actions.c:634:1: warning: symbol 'ovs_dst_get_mtu' was >> not declared. Should it be static

Re: [PATCHv2 net-next 5/9] openvswitch: Add conntrack action

2015-08-06 Thread Joe Stringer
On 5 August 2015 at 15:31, Pravin Shelar wrote: > On Tue, Aug 4, 2015 at 9:49 PM, Joe Stringer wrote: > I got sparse warning: > > net/openvswitch/actions.c:634:1: warning: symbol 'ovs_dst_get_mtu' was > not declared. Should it be static? > > net/openvswitch/actions.c:703:17: warning: cast from re

Re: [PATCHv2 net-next 5/9] openvswitch: Add conntrack action

2015-08-05 Thread Pravin Shelar
On Tue, Aug 4, 2015 at 9:49 PM, Joe Stringer wrote: > Expose the kernel connection tracker via OVS. Userspace components can > make use of the "ct()" action, followed by "recirculate", to populate > the conntracking state in the OVS flow key, and subsequently match on > that state. > > Example ODP