RE: [PATCHv3 3/7] driver, misc: add Intel Stratix10 service layer driver

2018-04-24 Thread David Laight
From: Greg KH > Sent: 23 April 2018 13:03 > On Tue, Mar 27, 2018 at 03:20:10PM -0500, richard.g...@linux.intel.com wrote: > > +config INTEL_SERVICE > > Naming is hard, but this is a _very_ generic name, don't you agree? > > > + tristate "Intel Service Layer" > > As is this. Can you make this

Re: [PATCHv3 3/7] driver, misc: add Intel Stratix10 service layer driver

2018-04-23 Thread Greg KH
On Tue, Mar 27, 2018 at 03:20:10PM -0500, richard.g...@linux.intel.com wrote: > +config INTEL_SERVICE Naming is hard, but this is a _very_ generic name, don't you agree? > + tristate "Intel Service Layer" As is this. Can you make this a bit more specific to what hardware is being controlled