Re: [PATCHv4 08/10] backlight: add TI LMU backlight driver

2018-04-09 Thread Pavel Machek
Hi! > > > +static int ti_lmu_bl_add_device(struct ti_lmu_bank *lmu_bank) > > > +{ > > > + switch (lmu_bank->type) { > > > + case TI_LMU_BL: > > > + return ti_lmu_bl_register_backlight(lmu_bank); > > > + case TI_LMU_LED: > > > + return ti_lmu_bl_register_led(lmu_bank); > > > + defau

Re: [PATCHv4 08/10] backlight: add TI LMU backlight driver

2018-04-09 Thread Sebastian Reichel
Hi Daniel, On Wed, Apr 04, 2018 at 03:57:39PM +0100, Daniel Thompson wrote: > On Fri, Mar 30, 2018 at 07:24:12PM +0200, Sebastian Reichel wrote: > > This adds backlight support for the following TI LMU > > chips: LM3532, LM3631, LM3632, LM3633, LM3695 and LM3697. > > > > Signed-off-by: Milo Kim

Re: [PATCHv4 08/10] backlight: add TI LMU backlight driver

2018-04-09 Thread Sebastian Reichel
Hi, On Wed, Apr 04, 2018 at 01:30:37PM -0500, Dan Murphy wrote: > Sebastian > > -Milo Kim email is not valid Thanks for your review! Milo was CC'd, since git took over the SoB. I will make sure to avoid it next time. > On 03/30/2018 12:24 PM, Sebastian Reichel wrote: > > This adds backlight sup

Re: [PATCHv4 08/10] backlight: add TI LMU backlight driver

2018-04-09 Thread Sebastian Reichel
Hi, On Tue, Apr 03, 2018 at 12:49:08PM +0200, Pavel Machek wrote: > > +enum ti_lmu_bl_type { > > + TI_LMU_BL, /* backlight userspace interface */ > > + TI_LMU_LED, /* led userspace interface */ > > +}; > ... > > +static int ti_lmu_bl_add_device(struct ti_lmu_bank *lmu_bank) > > +{ > > + swi

Re: [PATCHv4 08/10] backlight: add TI LMU backlight driver

2018-04-04 Thread Dan Murphy
Sebastian -Milo Kim email is not valid On 03/30/2018 12:24 PM, Sebastian Reichel wrote: > This adds backlight support for the following TI LMU > chips: LM3532, LM3631, LM3632, LM3633, LM3695 and LM3697. > > Signed-off-by: Milo Kim > [add LED subsystem support for keyboard backlight and rework D

Re: [PATCHv4 08/10] backlight: add TI LMU backlight driver

2018-04-04 Thread Daniel Thompson
On Fri, Mar 30, 2018 at 07:24:12PM +0200, Sebastian Reichel wrote: > This adds backlight support for the following TI LMU > chips: LM3532, LM3631, LM3632, LM3633, LM3695 and LM3697. > > Signed-off-by: Milo Kim > [add LED subsystem support for keyboard backlight and rework DT Milo's mail has be b

Re: [PATCHv4 08/10] backlight: add TI LMU backlight driver

2018-04-03 Thread Pavel Machek
Hi! > +enum ti_lmu_bl_type { > + TI_LMU_BL, /* backlight userspace interface */ > + TI_LMU_LED, /* led userspace interface */ > +}; ... > +static int ti_lmu_bl_add_device(struct ti_lmu_bank *lmu_bank) > +{ > + switch (lmu_bank->type) { > + case TI_LMU_BL: > + return ti