Re: [PATCHv5,RESEND 8/8] drm: tegra: Add gr2d device

2013-02-11 Thread Terje Bergström
On 10.02.2013 22:44, Thierry Reding wrote: > On Sun, Feb 10, 2013 at 04:42:53PM -0800, Terje Bergström wrote: >> You're right about performance. We already saw quite a bad performance >> hit with the current firewall, so we'll need to worry about performance >> later. > > I guess the additional ov

Re: [PATCHv5,RESEND 8/8] drm: tegra: Add gr2d device

2013-02-10 Thread Thierry Reding
On Sun, Feb 10, 2013 at 04:42:53PM -0800, Terje Bergström wrote: > On 07.02.2013 23:07, Thierry Reding wrote: > > On Wed, Feb 06, 2013 at 01:23:17PM -0800, Terje Bergström wrote: > That's the security firewall. It walks through each submit, and ensures > that each register write that writ

Re: [PATCHv5,RESEND 8/8] drm: tegra: Add gr2d device

2013-02-10 Thread Terje Bergström
On 07.02.2013 23:07, Thierry Reding wrote: > On Wed, Feb 06, 2013 at 01:23:17PM -0800, Terje Bergström wrote: That's the security firewall. It walks through each submit, and ensures that each register write that writes an address, goes through the host1x reloc mechanism. This way use

Re: [PATCHv5,RESEND 8/8] drm: tegra: Add gr2d device

2013-02-07 Thread Thierry Reding
On Wed, Feb 06, 2013 at 01:23:17PM -0800, Terje Bergström wrote: > On 05.02.2013 01:54, Thierry Reding wrote: > > On Mon, Feb 04, 2013 at 09:17:45PM -0800, Terje Bergström wrote: > >> Yeah, it's actually working around the host1x duplicate naming. > >> host1x_syncpt_get takes struct host1x as param

Re: [PATCHv5,RESEND 8/8] drm: tegra: Add gr2d device

2013-02-06 Thread Terje Bergström
On 05.02.2013 01:54, Thierry Reding wrote: > On Mon, Feb 04, 2013 at 09:17:45PM -0800, Terje Bergström wrote: >> Yeah, it's actually working around the host1x duplicate naming. >> host1x_syncpt_get takes struct host1x as parameter, but that's different >> host1x than in this code. > > So maybe a b

Re: [PATCHv5,RESEND 8/8] drm: tegra: Add gr2d device

2013-02-05 Thread Thierry Reding
On Mon, Feb 04, 2013 at 09:17:45PM -0800, Terje Bergström wrote: > On 04.02.2013 04:56, Thierry Reding wrote: > > On Tue, Jan 15, 2013 at 01:44:04PM +0200, Terje Bergstrom wrote: > >> +{ > >> + struct host1x *host1x = drm->dev_private; > >> + struct tegra_drm_syncpt_read_args *args = data;

Re: [PATCHv5,RESEND 8/8] drm: tegra: Add gr2d device

2013-02-04 Thread Terje Bergström
On 04.02.2013 04:56, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Tue, Jan 15, 2013 at 01:44:04PM +0200, Terje Bergstrom wrote: > [...] >> diff --git a/drivers/gpu/host1x/drm/drm.c b/drivers/gpu/host1x/drm/drm.c >> @@ -270,7 +274,29 @@ static int tegra_drm_unload(struct drm_device

Re: [PATCHv5,RESEND 8/8] drm: tegra: Add gr2d device

2013-02-04 Thread Thierry Reding
On Tue, Jan 15, 2013 at 01:44:04PM +0200, Terje Bergstrom wrote: [...] > diff --git a/drivers/gpu/host1x/drm/drm.c b/drivers/gpu/host1x/drm/drm.c > @@ -270,7 +274,29 @@ static int tegra_drm_unload(struct drm_device *drm) > > static int tegra_drm_open(struct drm_device *drm, struct drm_file *filp