Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-06-11 Thread Mark Brown
On Thu, Jun 05, 2014 at 07:12:05AM -0400, Matt Porter wrote: > On Tue, Jun 03, 2014 at 03:51:55PM +0530, Jassi Brar wrote: > > BTW, here we at least have a hardware resource to specify in the DT > > node, there are examples in kernel where the DT nodes are purely > > virtual. For ex, grep for "lin

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-06-11 Thread Mark Brown
On Wed, May 28, 2014 at 09:50:21AM +0530, Jassi Brar wrote: > On Wed, May 21, 2014 at 10:57 PM, Mark Brown wrote: > >> + if (!cl->tx_tout) /* wait for ever */ > >> + cl->tx_tout = msecs_to_jiffies(360); > >> + else > >> + cl->tx_tout = msecs_to_jiffies(cl->tx_t

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-06-05 Thread Jassi Brar
On 5 June 2014 16:42, Matt Porter wrote: > On Tue, Jun 03, 2014 at 03:51:55PM +0530, Jassi Brar wrote: > >> BTW, here we at least have a hardware resource to specify in the DT >> node, there are examples in kernel where the DT nodes are purely >> virtual. For ex, grep for "linux,spdif-dit". So I t

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-06-05 Thread Matt Porter
On Tue, Jun 03, 2014 at 03:51:55PM +0530, Jassi Brar wrote: > On 3 June 2014 15:05, Sudeep Holla wrote: > > Hi Jassi, > > > > On Mon, Jun 2, 2014 at 6:11 PM, Jassi Brar wrote: > >> On Mon, Jun 2, 2014 at 8:44 PM, Matt Porter wrote: > >>> On Fri, May 30, 2014 at 11:01:55AM +0530, Jassi Brar wrote

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-06-03 Thread Sudeep Holla
Hi Jassi, On 03/06/14 11:21, Jassi Brar wrote: On 3 June 2014 15:05, Sudeep Holla wrote: Hi Jassi, On Mon, Jun 2, 2014 at 6:11 PM, Jassi Brar wrote: On Mon, Jun 2, 2014 at 8:44 PM, Matt Porter wrote: On Fri, May 30, 2014 at 11:01:55AM +0530, Jassi Brar wrote: Being more specific to yo

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-06-03 Thread Jassi Brar
On 3 June 2014 15:05, Sudeep Holla wrote: > Hi Jassi, > > On Mon, Jun 2, 2014 at 6:11 PM, Jassi Brar wrote: >> On Mon, Jun 2, 2014 at 8:44 PM, Matt Porter wrote: >>> On Fri, May 30, 2014 at 11:01:55AM +0530, Jassi Brar wrote: >>> Being more specific to your platform, I think you need some

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-06-03 Thread Sudeep Holla
Hi Jassi, On Mon, Jun 2, 2014 at 6:11 PM, Jassi Brar wrote: > On Mon, Jun 2, 2014 at 8:44 PM, Matt Porter wrote: >> On Fri, May 30, 2014 at 11:01:55AM +0530, Jassi Brar wrote: >> >>> Being more specific to your platform, I think you need some server >>> code (mailbox's client) that every driver

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-06-02 Thread Matt Porter
[Adding devicetree list] On Mon, Jun 02, 2014 at 10:41:44PM +0530, Jassi Brar wrote: > On Mon, Jun 2, 2014 at 8:44 PM, Matt Porter wrote: > > On Fri, May 30, 2014 at 11:01:55AM +0530, Jassi Brar wrote: > > > >> Being more specific to your platform, I think you need some server > >> code (mailbox

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-06-02 Thread Jassi Brar
On Mon, Jun 2, 2014 at 8:44 PM, Matt Porter wrote: > On Fri, May 30, 2014 at 11:01:55AM +0530, Jassi Brar wrote: > >> Being more specific to your platform, I think you need some server >> code (mailbox's client) that every driver (like clock, pmu, pinmux >> etc) registers with to send messages to

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-06-02 Thread Matt Porter
On Fri, May 30, 2014 at 11:01:55AM +0530, Jassi Brar wrote: > On Thu, May 29, 2014 at 9:13 PM, Matt Porter wrote: > > On Fri, May 16, 2014 at 07:03:25PM +0530, Jassi Brar wrote: > >> On 15 May 2014 19:57, Arnd Bergmann wrote: > >> > On Thursday 15 May 2014 11:41:00 Jassi Brar wrote: > > > > ... >

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-05-29 Thread Jassi Brar
On Thu, May 29, 2014 at 9:13 PM, Matt Porter wrote: > On Fri, May 16, 2014 at 07:03:25PM +0530, Jassi Brar wrote: >> On 15 May 2014 19:57, Arnd Bergmann wrote: >> > On Thursday 15 May 2014 11:41:00 Jassi Brar wrote: > > ... > >> >> +struct mbox_controller { >> >> + struct device *dev; >> >> +

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-05-29 Thread Matt Porter
On Fri, May 16, 2014 at 07:03:25PM +0530, Jassi Brar wrote: > On 15 May 2014 19:57, Arnd Bergmann wrote: > > On Thursday 15 May 2014 11:41:00 Jassi Brar wrote: ... > >> +struct mbox_controller { > >> + struct device *dev; > >> + struct mbox_chan_ops *ops; > >> + struct mbox_chan *cha

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-05-28 Thread Suman Anna
On 05/27/2014 11:20 PM, Jassi Brar wrote: > On Wed, May 21, 2014 at 10:57 PM, Mark Brown wrote: >> On Thu, May 15, 2014 at 11:41:00AM +0530, Jassi Brar wrote: >>> Introduce common framework for client/protocol drivers and >>> controller drivers of Inter-Processor-Communication (IPC). >> >> This lo

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-05-27 Thread Jassi Brar
On Wed, May 21, 2014 at 10:57 PM, Mark Brown wrote: > On Thu, May 15, 2014 at 11:41:00AM +0530, Jassi Brar wrote: >> Introduce common framework for client/protocol drivers and >> controller drivers of Inter-Processor-Communication (IPC). > > This looks pretty nice, though I do have a few *very* sm

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-05-21 Thread Arnd Bergmann
On Wednesday 21 May 2014 18:27:01 Mark Brown wrote: > > + /* The queued TX requests are simply aborted, no callbacks are made */ > > + spin_lock_irqsave(&chan->lock, flags); > > + chan->cl = NULL; > > + chan->active_req = NULL; > > + if (chan->txdone_method == (TXDONE_BY_POLL |

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-05-21 Thread Mark Brown
On Thu, May 15, 2014 at 11:41:00AM +0530, Jassi Brar wrote: > Introduce common framework for client/protocol drivers and > controller drivers of Inter-Processor-Communication (IPC). This looks pretty nice, though I do have a few *very* small nits beyond those Arnd had. > + if (chan->cl->tx_bl

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-05-20 Thread Jassi Brar
On Tue, May 20, 2014 at 1:25 AM, Bjorn Andersson wrote: > On Mon, May 19, 2014 at 11:03 AM, Jassi Brar > wrote: >> On 19 May 2014 18:38, Arnd Bergmann wrote: >>> On Friday 16 May 2014 19:03:25 Jassi Brar wrote: > [...] >>> Do you have an example for a platform like that? I'd expect that normall

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-05-19 Thread Arnd Bergmann
On Monday 19 May 2014 12:55:51 Bjorn Andersson wrote: > On Mon, May 19, 2014 at 11:03 AM, Jassi Brar > wrote: > > On 19 May 2014 18:38, Arnd Bergmann wrote: > >> On Friday 16 May 2014 19:03:25 Jassi Brar wrote: > [...] > >> Do you have an example for a platform like that? I'd expect that normall

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-05-19 Thread Bjorn Andersson
On Mon, May 19, 2014 at 11:03 AM, Jassi Brar wrote: > On 19 May 2014 18:38, Arnd Bergmann wrote: >> On Friday 16 May 2014 19:03:25 Jassi Brar wrote: [...] >> Do you have an example for a platform like that? I'd expect that normally >> we can have a boot loader that sets up the system timer to wor

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-05-19 Thread Jassi Brar
On 19 May 2014 18:38, Arnd Bergmann wrote: > On Friday 16 May 2014 19:03:25 Jassi Brar wrote: > >> Also, some platform might need to communicate with remote master >> during very early boot like for initializing system timers and clocks. >> The API isn't working then. > > Do you have an example

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-05-19 Thread Arnd Bergmann
On Friday 16 May 2014 19:03:25 Jassi Brar wrote: > >> +/** > >> + * struct mbox_controller - Controller of a class of communication chans > >> + * @dev: Device backing this controller > >> + * @controller_name: Literal name of the controller. > >> + * @ops: Operators that wo

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-05-16 Thread Jassi Brar
On 15 May 2014 19:57, Arnd Bergmann wrote: > On Thursday 15 May 2014 11:41:00 Jassi Brar wrote: >> Introduce common framework for client/protocol drivers and >> controller drivers of Inter-Processor-Communication (IPC). >> >> Client driver developers should have a look at >> include/linux/mailbox

Re: [PATCHv5 2/4] mailbox: Introduce framework for mailbox

2014-05-15 Thread Arnd Bergmann
On Thursday 15 May 2014 11:41:00 Jassi Brar wrote: > Introduce common framework for client/protocol drivers and > controller drivers of Inter-Processor-Communication (IPC). > > Client driver developers should have a look at > include/linux/mailbox_client.h to understand the part of > the API expo